Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(481)

Issue 6452058: code review 6452058: goauth2: adding a jwt package to support server to serv...

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by gavaletz_google
Modified:
2 months ago
CC:
bradfitzgoog, golang-codereviews, tiziana
Visibility:
Public.

Description

goauth2: adding a jwt package to support server to server applications. The jwt package allows the user to define a jwt.Token containing the required and optional fields for constructing the serialized and encoded JWT to be used for requesting an access_token. Integrating this package into oauth/oauth.go will require some redesign of the parent package. These changes have been postponed for a later CL. The descriptions of the standards this change implements can be found on the following web page. https://developers.google.com/accounts/docs/OAuth2ServiceAccount This addition to the library will allow for example a GAE instance to make requests to service like BigQuery.

Patch Set 1 #

Patch Set 2 : diff -r ae891eec7124 https://code.google.com/p/goauth2/ #

Total comments: 12

Patch Set 3 : diff -r ae891eec7124 https://code.google.com/p/goauth2/ #

Total comments: 4

Patch Set 4 : diff -r ae891eec7124 https://code.google.com/p/goauth2/ #

Total comments: 11

Patch Set 5 : diff -r ae891eec7124 https://code.google.com/p/goauth2/ #

Total comments: 1

Patch Set 6 : diff -r ae891eec7124 https://code.google.com/p/goauth2/ #

Patch Set 7 : diff -r ae891eec7124 https://code.google.com/p/goauth2/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+709 lines, -0 lines) Patch
A oauth/jwt/jwt.go View 1 2 3 4 5 6 1 chunk +310 lines, -0 lines 0 comments Download
A oauth/jwt/jwt_test.go View 1 2 3 4 5 1 chunk +399 lines, -0 lines 0 comments Download

Messages

Total messages: 39
gavaletz_google
Hello adg@google.com (cc: bradfitz@google.com, golang-dev@googlegroups.com, jcgregorio@google.com, tiziana@google.com), I'd like you to review this change to ...
8 years, 7 months ago (2012-07-27 21:05:56 UTC) #1
adg
I am still thinking about how to integrate. I think this approach is wrong. One ...
8 years, 7 months ago (2012-07-30 09:24:26 UTC) #2
gavaletz_google
I just need to know that we are all on the same page, and that ...
8 years, 7 months ago (2012-07-30 16:00:20 UTC) #3
jcgregorio_google
On Mon, Jul 30, 2012 at 11:59 AM, Eric Gavaletz <gavaletz@google.com> wrote: > I just ...
8 years, 7 months ago (2012-07-30 16:50:05 UTC) #4
gavaletz_google
Borrowing from your public thoughts on the subject: "Breaking the protocol apart into separate flows ...
8 years, 7 months ago (2012-07-30 17:45:29 UTC) #5
adg1
In its current state, we might as well put a function in the jwt package ...
8 years, 7 months ago (2012-08-01 07:43:17 UTC) #6
adg
http://codereview.appspot.com/6452058/diff/1001/oauth/jwt/jwt.go File oauth/jwt/jwt.go (right): http://codereview.appspot.com/6452058/diff/1001/oauth/jwt/jwt.go#newcode48 oauth/jwt/jwt.go:48: type Segment interface { This doesn't seem to be ...
8 years, 7 months ago (2012-08-01 07:45:19 UTC) #7
gavaletz_google
Responding to feedback. http://codereview.appspot.com/6452058/diff/1001/oauth/jwt/jwt.go File oauth/jwt/jwt.go (right): http://codereview.appspot.com/6452058/diff/1001/oauth/jwt/jwt.go#newcode8 oauth/jwt/jwt.go:8: "../../oauth" On 2012/07/30 09:24:26, adg wrote: ...
8 years, 7 months ago (2012-08-01 18:54:04 UTC) #8
gavaletz_google
Hello adg@google.com, adg@golang.org (cc: bradfitz@google.com, golang-dev@googlegroups.com, jcgregorio@google.com, tiziana@google.com), Please take another look.
8 years, 7 months ago (2012-08-01 19:00:09 UTC) #9
jcgregorio_google
http://codereview.appspot.com/6452058/diff/7004/oauth/jwt/jwt.go File oauth/jwt/jwt.go (right): http://codereview.appspot.com/6452058/diff/7004/oauth/jwt/jwt.go#newcode100 oauth/jwt/jwt.go:100: // one hour from then (or the time in ...
8 years, 7 months ago (2012-08-02 18:41:22 UTC) #10
gavaletz_google
http://codereview.appspot.com/6452058/diff/7004/oauth/jwt/jwt.go File oauth/jwt/jwt.go (right): http://codereview.appspot.com/6452058/diff/7004/oauth/jwt/jwt.go#newcode100 oauth/jwt/jwt.go:100: // one hour from then (or the time in ...
8 years, 7 months ago (2012-08-02 19:09:37 UTC) #11
jcgregorio_google
http://codereview.appspot.com/6452058/diff/7004/oauth/jwt/jwt.go File oauth/jwt/jwt.go (right): http://codereview.appspot.com/6452058/diff/7004/oauth/jwt/jwt.go#newcode100 oauth/jwt/jwt.go:100: // one hour from then (or the time in ...
8 years, 7 months ago (2012-08-02 19:20:58 UTC) #12
gavaletz_google
Hello adg@google.com, adg@golang.org, jcgregorio@google.com (cc: bradfitz@google.com, golang-dev@googlegroups.com, tiziana@google.com), Please take another look.
8 years, 7 months ago (2012-08-02 19:44:36 UTC) #13
gavaletz_google
http://codereview.appspot.com/6452058/diff/7004/oauth/jwt/jwt.go File oauth/jwt/jwt.go (right): http://codereview.appspot.com/6452058/diff/7004/oauth/jwt/jwt.go#newcode100 oauth/jwt/jwt.go:100: // one hour from then (or the time in ...
8 years, 7 months ago (2012-08-02 19:45:36 UTC) #14
adg
http://codereview.appspot.com/6452058/diff/7005/oauth/jwt/jwt.go File oauth/jwt/jwt.go (right): http://codereview.appspot.com/6452058/diff/7005/oauth/jwt/jwt.go#newcode35 oauth/jwt/jwt.go:35: StdAlgorithm = "RS256" these should be unexported http://codereview.appspot.com/6452058/diff/7005/oauth/jwt/jwt.go#newcode42 oauth/jwt/jwt.go:42: ...
8 years, 7 months ago (2012-08-06 02:01:03 UTC) #15
gavaletz_google
Sending update to CL 6452058. http://codereview.appspot.com/6452058/diff/7005/oauth/jwt/jwt.go File oauth/jwt/jwt.go (right): http://codereview.appspot.com/6452058/diff/7005/oauth/jwt/jwt.go#newcode35 oauth/jwt/jwt.go:35: StdAlgorithm = "RS256" On ...
8 years, 7 months ago (2012-08-06 16:30:52 UTC) #16
gavaletz_google
Hello adg@google.com, adg@golang.org, jcgregorio@google.com (cc: bradfitz@google.com, golang-dev@googlegroups.com, tiziana@google.com), Please take another look.
8 years, 7 months ago (2012-08-06 16:32:51 UTC) #17
gavaletz_google
Possible issue making use of the .p12 file that Google API console gives us when ...
8 years, 7 months ago (2012-08-06 17:44:47 UTC) #18
adg
Am I still waiting on an additional change from you?
8 years, 7 months ago (2012-08-08 00:43:15 UTC) #19
gavaletz_google
Yes, and given the feedback that Joe has gotten on the issue with the .p12 ...
8 years, 7 months ago (2012-08-08 00:50:36 UTC) #20
adg1
On 8 August 2012 10:50, Eric Gavaletz <gavaletz@google.com> wrote: > Yes, and given the feedback ...
8 years, 7 months ago (2012-08-08 00:51:44 UTC) #21
gavaletz_google
Hello adg@google.com, adg@golang.org, jcgregorio@google.com (cc: bradfitz@google.com, golang-dev@googlegroups.com, tiziana@google.com), Please take another look.
8 years, 7 months ago (2012-08-10 20:26:59 UTC) #22
gavaletz_google
Hello adg@google.com, adg@golang.org, jcgregorio@google.com (cc: bradfitz@google.com, golang-dev@googlegroups.com, tiziana@google.com), Please take another look.
8 years, 7 months ago (2012-08-10 20:28:59 UTC) #23
gavaletz_google
Today is my last day at Google (at least for the next year). I would ...
8 years, 7 months ago (2012-08-10 20:32:24 UTC) #24
iant2
On Fri, Aug 10, 2012 at 1:32 PM, Eric Gavaletz <gavaletz@google.com> wrote: > Today is ...
8 years, 7 months ago (2012-08-10 20:58:19 UTC) #25
gavaletz_google
Since this CL has a fair amount of history I guess the better question would ...
8 years, 7 months ago (2012-08-10 21:02:12 UTC) #26
iant2
On Fri, Aug 10, 2012 at 2:01 PM, Eric Gavaletz <gavaletz@google.com> wrote: > Since this ...
8 years, 7 months ago (2012-08-10 21:14:54 UTC) #27
gavaletz
I am getting back to work at my university and was wondering what further feedback ...
8 years, 6 months ago (2012-08-21 19:41:49 UTC) #28
adg1
On 22 August 2012 05:41, <gavaletz@gmail.com> wrote: > I am getting back to work at ...
8 years, 6 months ago (2012-08-22 01:50:02 UTC) #29
adg1
You can't. You must start a new one. The history is still there. Just cite ...
8 years, 6 months ago (2012-08-22 12:14:01 UTC) #30
shaan7
Did anything happen after this? I'm in need of a way to auth my AppEngine ...
6 years, 1 month ago (2015-01-10 06:59:25 UTC) #31
gobot
Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
6 years, 1 month ago (2015-01-10 07:01:14 UTC) #32
bradfitz
Burcu, Does this old CL add anything over the service account stuff we already have? ...
6 years, 1 month ago (2015-01-13 02:12:26 UTC) #33
jbd
No, it doesn't. You can close it. On Mon, Jan 12, 2015 at 6:12 PM, ...
6 years, 1 month ago (2015-01-13 04:33:00 UTC) #34
gun20toro
3 months, 3 weeks ago (2020-11-13 05:03:46 UTC) #35
改三小
3 months, 2 weeks ago (2020-11-21 03:29:55 UTC) #36
zhtw1234 baby546833都是我,我叫周訓毅專幹你娘,老雞歪也很愛
3 months, 2 weeks ago (2020-11-21 03:36:26 UTC) #37
zhtw1234 baby546833都是我,我叫周訓毅專幹你娘,老雞歪也很愛
3 months, 2 weeks ago (2020-11-21 03:36:51 UTC) #38
2 months ago (2021-01-01 03:49:11 UTC) #39
https://codereview.appspot.com/6452058/diff/1001/oauth/jwt/jwt.go
File oauth/jwt/jwt.go (right):

https://codereview.appspot.com/6452058/diff/1001/oauth/jwt/jwt.go#newcode8
oauth/jwt/jwt.go:8: "../../oauth"
On 2012/08/01 18:54:04, gavaletz_google wrote:
> <font style="vertical-align: inherit;"><font style="vertical-align:
inherit;">在2012/07/30 09:24:26,adg寫道:> code.google.com/p/goauth2/oauth
> 
> </font></font>
> <font style="vertical-align: inherit;"><font style="vertical-align:
inherit;">已經進行了更改;</font><font style="vertical-align:
inherit;">但是,我現在無法運行測試。</font><font style="vertical-align: inherit;">為了開始項目,我使用“
hg clone </font></font>https://code.google.com/p/goauth2/%22<font
style="vertical-align: inherit;"><font style="vertical-align: inherit;">簽出了代碼
幹
你
娘
老
雞
歪

https://codereview.appspot.com/6452058/diff/1001/oauth/jwt/jwt.go#newcode225
oauth/jwt/jwt.go:225: func (t *Token) BuildRequest() (*http.Request, error) {
不要臉,已婚的男人周訓毅剛好就好不要找難看
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b