Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(591)

Issue 64510043: code review 64510043: os: handle file creation with close-on-exec flag correctly on darwin, freebsd (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by mikio
Modified:
6 years, 10 months ago
Reviewers:
gobot, bradfitz
CC:
golang-codereviews, dfc, rsc, minux1, bradfitz
Visibility:
Public.

Description

os: handle file creation with close-on-exec flag correctly on darwin, freebsd Fixes issue 7187. Update issue 7193

Patch Set 1 : diff -r bca0032e86af https://code.google.com/p/go #

Total comments: 5

Patch Set 2 : diff -r abd51e52924a https://code.google.com/p/go #

Patch Set 3 : diff -r f62cd90ce0d8 https://code.google.com/p/go #

Patch Set 4 : diff -r 1a72d2295c21 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -6 lines) Patch
M src/pkg/os/file_unix.go View 1 1 chunk +1 line, -6 lines 0 comments Download
A src/pkg/os/sys_darwin.go View 1 1 chunk +31 lines, -0 lines 0 comments Download
A src/pkg/os/sys_freebsd.go View 1 1 chunk +23 lines, -0 lines 0 comments Download
A src/pkg/os/sys_nacl.go View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A src/pkg/os/sys_unix.go View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 17
mikio
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
6 years, 10 months ago (2014-02-26 06:54:43 UTC) #1
dfc
Thanks for taking a look at this. Is it possible to do this via a ...
6 years, 10 months ago (2014-02-26 07:49:38 UTC) #2
mikio
> Thanks for taking a look at this. Is it possible to do this via ...
6 years, 10 months ago (2014-02-26 07:52:10 UTC) #3
dfc
Have a look at my comments, hopefully they make sense. On Wed, Feb 26, 2014 ...
6 years, 10 months ago (2014-02-26 07:55:16 UTC) #4
mikio
On 2014/02/26 07:55:16, dfc wrote: > Have a look at my comments, hopefully they make ...
6 years, 10 months ago (2014-02-26 07:56:59 UTC) #5
dfc
Anything we can push into the compiler makes the runtime start faster, less init() functions, ...
6 years, 10 months ago (2014-02-26 07:57:50 UTC) #6
mikio
> Anything we can push into the compiler makes the runtime start faster, less > ...
6 years, 10 months ago (2014-02-26 08:06:09 UTC) #7
dfc
> > anything? hm, i`ll check your contributed code later. :) > Heh. Well, anything ...
6 years, 10 months ago (2014-02-26 08:11:33 UTC) #8
mikio
Hello golang-codereviews@googlegroups.com, dave@cheney.net (cc: golang-codereviews@googlegroups.com), Please take another look.
6 years, 10 months ago (2014-02-26 11:25:29 UTC) #9
mikio
Hello golang-codereviews@googlegroups.com, dave@cheney.net, rsc@golang.org, minux.ma@gmail.com (cc: golang-codereviews@googlegroups.com), Please take another look.
6 years, 10 months ago (2014-02-27 15:50:24 UTC) #10
bradfitz
LGTM but add support for the "nacl" GOOS first, otherwise it won't compile.
6 years, 10 months ago (2014-02-27 22:25:30 UTC) #11
mikio
wait for nacl landing. also added sys_nacl.go and solaris tag to sys_unix.go
6 years, 10 months ago (2014-02-28 01:20:56 UTC) #12
dfc
I'm fine with you submitting this now. I'm pretty sure nacl isn't going to work ...
6 years, 10 months ago (2014-02-28 02:15:03 UTC) #13
rsc
Please feel free to break NaCl as you see fit, until there is a builder ...
6 years, 10 months ago (2014-02-28 02:22:33 UTC) #14
mikio
thanks, but i realised that this cl alos requires freebsd10 cls. On Fri, Feb 28, ...
6 years, 10 months ago (2014-02-28 02:47:13 UTC) #15
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=8269523252e1 *** os: handle file creation with close-on-exec flag correctly on darwin, ...
6 years, 10 months ago (2014-03-04 00:27:33 UTC) #16
gobot
6 years, 10 months ago (2014-03-04 04:32:23 UTC) #17
Message was sent while issue was closed.
This CL appears to have broken the linux-amd64-race builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b