Issue 6450103: cmd/juju: add unexpose

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6450103: cmd/juju: add unexpose (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by dave

Modified:
11 years, 8 months ago

Reviewers:
mp+118462

Visibility:
Public.

Description

cmd/juju: add unexpose Unexpose unexposes exposed services previously exposed with juju expose. https://code.launchpad.net/~dave-cheney/juju-core/go-cmd-juju-unexpose/+merge/118462 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/juju: add unexpose #

Total comments: 2

Patch Set 3 : cmd/juju: add unexpose #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -0 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/cmd_test.go	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
M	cmd/juju/main.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	cmd/juju/main_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	cmd/juju/unexpose.go	View	1 2	1 chunk	+51 lines, -0 lines	0 comments	Download
A	cmd/juju/unexpose_test.go	View	1	1 chunk	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6450103/diff/1009/cmd/juju/unexpose.go File cmd/juju/unexpose.go (right): https://codereview.appspot.com/6450103/diff/1009/cmd/juju/unexpose.go#newcode33 cmd/juju/unexpose.go:33: return cmd.CheckEmpty(args[1:]) The switch statement seems a bit ...

11 years, 8 months ago (2012-08-13 17:33:48 UTC) #2

dave_cheney.net

11 years, 8 months ago (2012-08-13 23:48:28 UTC) #3

*** Submitted:

cmd/juju: add unexpose

Unexpose unexposes exposed services previously exposed with juju expose.

R=niemeyer
CC=
https://codereview.appspot.com/6450103

https://codereview.appspot.com/6450103/diff/1009/cmd/juju/unexpose.go
File cmd/juju/unexpose.go (right):

https://codereview.appspot.com/6450103/diff/1009/cmd/juju/unexpose.go#newcode33
cmd/juju/unexpose.go:33: return cmd.CheckEmpty(args[1:])
> The switch statement seems a bit like unnecessary noise here. Is "expose" like
> that too?

Yup, and the code that expose was copied from. I will propose a branch that
fixes those commands.

Expand All Messages | Collapse All Messages