Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 6446088: code review 6446088: cmd/6g: backport byte mov optimization from 8g. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by remyoudompheng
Modified:
10 years, 3 months ago
Reviewers:
rsc, golang-dev
CC:
golang-dev, remy_archlinux.org
Visibility:
Public.

Description

cmd/6g: backport byte mov optimization from 8g. benchmark old ns/op new ns/op delta BenchmarkLoop8 342 294 -14.04% BenchmarkRange8 560 306 -45.36% BenchmarkLoop16 346 293 -15.32% BenchmarkRange16 564 304 -46.10% Fixes issue 3909.

Patch Set 1 #

Patch Set 2 : diff -r 422b4a8160bc https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 422b4a8160bc https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/cmd/6g/peep.c View 1 6 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 4 months ago (2012-08-05 08:46:24 UTC) #1
remyoudompheng
Shold I also include the movb elimination part? I am not sure what is its ...
10 years, 4 months ago (2012-08-05 08:47:12 UTC) #2
rsc
There are some bugs in this part of the optimizer involving getting confused by short ...
10 years, 4 months ago (2012-08-05 17:00:07 UTC) #3
remyoudompheng
On 2012/8/5 Russ Cox <rsc@golang.org>: > There are some bugs in this part of the ...
10 years, 4 months ago (2012-08-05 18:15:44 UTC) #4
remyoudompheng
A patch suggestion could be: http://codereview.appspot.com/6459046
10 years, 4 months ago (2012-08-05 18:18:06 UTC) #5
rsc
There's a bigger issue here. The optimizer gets confused because it is stuck in the ...
10 years, 4 months ago (2012-08-05 22:12:08 UTC) #6
remyoudompheng
On 2012/8/6 Russ Cox <rsc@golang.org> wrote: > Anyway, I have been wondering if we should ...
10 years, 4 months ago (2012-08-06 10:12:36 UTC) #7
remyoudompheng
10 years, 3 months ago (2012-09-01 14:43:41 UTC) #8
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b