Issue 6441126: Use ipAddress as a fallback for dnsName

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6441126: Use ipAddress as a fallback for dnsName

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by SpamapS

Modified:
8 years, 4 months ago

Reviewers:
mp+119021

Visibility:
Public.

Description

Use ipAddress as a fallback for dnsName Use ipAddress as a fallback if dnsName is unresolvable https://code.launchpad.net/~clint-fewbar/juju/ec2-use-ip-address/+merge/119021 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+165 lines, -16 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/providers/ec2/__init__.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	juju/providers/ec2/launch.py	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	juju/providers/ec2/machine.py	View	3 chunks	+30 lines, -4 lines	0 comments	Download
M	juju/providers/ec2/tests/common.py	View	3 chunks	+18 lines, -2 lines	0 comments	Download
M	juju/providers/ec2/tests/test_getmachines.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	juju/providers/ec2/tests/test_launch.py	View	3 chunks	+21 lines, -2 lines	0 comments	Download
M	juju/providers/ec2/tests/test_machine.py	View	1 chunk	+80 lines, -6 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Please take a look.

Expand All Messages | Collapse All Messages