Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(181)

Issue 6419074: standardise on "cannot" rather than "can't" in error messages.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by rog
Modified:
11 years, 8 months ago
Reviewers:
mp+116523
Visibility:
Public.

Description

standardise on "cannot" rather than "can't" in error messages. https://code.launchpad.net/~rogpeppe/juju-core/cannot/+merge/116523 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : standardise on "cannot" rather than "can't" in error messages. #

Patch Set 3 : standardise on "cannot" rather than "can't" in error messages. #

Patch Set 4 : standardise on "cannot" rather than "can't" in error messages. #

Patch Set 5 : standardise on "cannot" rather than "can't" in error messages. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -176 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/deploy.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/deploy_test.go View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M environs/ec2/config.go View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M environs/ec2/config_test.go View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M environs/tools_test.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mstate/assign_test.go View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M mstate/charm.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mstate/charm_test.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mstate/machine.go View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M mstate/sequence.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mstate/service.go View 1 2 8 chunks +11 lines, -11 lines 0 comments Download
M mstate/service_test.go View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M mstate/state.go View 1 2 10 chunks +10 lines, -10 lines 0 comments Download
M mstate/state_test.go View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M mstate/unit.go View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M state/assign_test.go View 1 2 6 chunks +10 lines, -10 lines 0 comments Download
M state/confignode.go View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M state/machine.go View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M state/machine_test.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M state/relation.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M state/relation_test.go View 1 2 8 chunks +16 lines, -16 lines 0 comments Download
M state/service.go View 1 2 11 chunks +11 lines, -11 lines 0 comments Download
M state/service_test.go View 1 2 9 chunks +11 lines, -11 lines 0 comments Download
M state/ssh.go View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M state/state.go View 1 2 16 chunks +16 lines, -16 lines 0 comments Download
M state/state_test.go View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
M state/topology.go View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M state/topology_test.go View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M state/unit.go View 1 2 19 chunks +19 lines, -19 lines 0 comments Download
M state/unit_test.go View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M state/util.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M state/watcher.go View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M state/watcher/watcher.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M state/watcher/watcher_test.go View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M store/server.go View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M worker/provisioner/provisioner.go View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
11 years, 8 months ago (2012-07-25 09:06:13 UTC) #1
niemeyer
LGTM
11 years, 8 months ago (2012-07-25 09:30:36 UTC) #2
rog
11 years, 8 months ago (2012-07-25 10:26:01 UTC) #3
*** Submitted:

standardise on "cannot" rather than "can't" in error messages.

R=niemeyer
CC=
https://codereview.appspot.com/6419074
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b