Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(263)

Issue 6419064: line_count related patches in a single commit for review

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by benko.pal
Modified:
6 years, 10 months ago
Reviewers:
Keith, dak, marc
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

line_count related patches in a single commit for review in decreasing order of importance: - make slurs symmetric to staff - improve time signature and bar line (in particular dots of a repeat sign) positioning under non-standard circumstances - enhance regtests - etc.

Patch Set 1 #

Total comments: 2

Patch Set 2 : regtests reorganized #

Patch Set 3 : new version of line-count fixes, without bar-line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -45 lines) Patch
A input/regression/repeat-sign.ly View 1 1 chunk +139 lines, -0 lines 0 comments Download
A input/regression/repeat-sign-global-size-10.ly View 1 1 chunk +43 lines, -0 lines 0 comments Download
A input/regression/repeat-sign-global-size-30.ly View 1 1 chunk +46 lines, -0 lines 0 comments Download
A input/regression/repeat-sign-layout-size.ly View 1 1 chunk +43 lines, -0 lines 0 comments Download
M input/regression/zero-staff-space.ly View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/beam.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M lily/breathing-sign.cc View 3 chunks +15 lines, -19 lines 0 comments Download
M lily/custos.cc View 2 chunks +1 line, -2 lines 0 comments Download
M lily/rest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M lily/rest-collision.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M lily/slur-scoring.cc View 1 chunk +1 line, -2 lines 0 comments Download
M lily/time-signature.cc View 2 chunks +30 lines, -2 lines 0 comments Download
M lily/vaticana-ligature.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9
benko.pal
when splitting the previous patch into smaller commits I added new regtests and found further ...
6 years, 11 months ago (2012-07-21 14:47:56 UTC) #1
Keith
`make check` succeeded for me, and I cannot see anything that would cause a problem ...
6 years, 11 months ago (2012-07-23 20:40:03 UTC) #2
benko.pal
regtests reorganized and explanations added
6 years, 11 months ago (2012-07-25 19:44:56 UTC) #3
benko.pal
the post-1320 version. Marc, please consider patch set 2 for bar-line related changes.
6 years, 10 months ago (2012-08-07 09:20:06 UTC) #4
benko.pal
hi Marc, 2012/8/7 Marc Hohl <marc@hohlart.de>: > Am 07.08.2012 11:20, schrieb benko.pal@gmail.com: > >> the ...
6 years, 10 months ago (2012-08-07 20:31:58 UTC) #5
benko.pal
hi Marc, > I noticed that your patch didn't include the changes > in bar-line.scm ...
6 years, 10 months ago (2012-08-10 17:00:32 UTC) #6
benko.pal
Marc, Keith, all, here is an intermediate report on how I stand with bar lines, ...
6 years, 10 months ago (2012-08-13 20:32:25 UTC) #7
benko.pal
hi all, >> Keith, I hope I fixed lyrics-bar.ly. > > > Yes, it comes ...
6 years, 10 months ago (2012-08-17 12:14:30 UTC) #8
benko.pal
6 years, 10 months ago (2012-08-20 20:26:57 UTC) #9
> I have now four commits: regtest changes plus one change
> in three (sort of unrelated) functions each in bar-line.scm
> (colon, extent and line-span computation).
> what review process do you prefer/suggest?
> one review per commit or review in one, push in four?

uploaded in a single commit for review:
http://codereview.appspot.com/6441166
http://code.google.com/p/lilypond/issues/detail?id=2762
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b