Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1284)

Issue 6398055: Volta enhancements tranche 1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by PhilEHolmes
Modified:
6 years, 11 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

The first set of changes proposed by Arnold Theresius.

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -7 lines) Patch
M Documentation/de/notation/repeats.itely View 1 chunk +20 lines, -1 line 1 comment Download
M Documentation/de/notation/rhythms.itely View 1 chunk +4 lines, -0 lines 0 comments Download
M Documentation/notation/repeats.itely View 1 chunk +18 lines, -0 lines 1 comment Download
M Documentation/notation/rhythms.itely View 1 chunk +4 lines, -0 lines 3 comments Download
M lily/repeat-acknowledge-engraver.cc View 3 chunks +32 lines, -6 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +13 lines, -0 lines 0 comments Download
M scm/define-context-properties.scm View 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4
PhilEHolmes
On behalf of Arnold Theresius. Please review.
6 years, 11 months ago (2012-07-17 17:37:47 UTC) #1
Ian Hulin (gmail)
Just some nit-picky comments re the English version of the documentation. Cheers, Ian http://codereview.appspot.com/6398055/diff/1/Documentation/notation/repeats.itely File ...
6 years, 11 months ago (2012-07-18 00:10:59 UTC) #2
dak
http://codereview.appspot.com/6398055/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/6398055/diff/1/Documentation/notation/rhythms.itely#newcode2676 Documentation/notation/rhythms.itely:2676: Additionally there is an @code{\inStaffSegno} command which On 2012/07/18 ...
6 years, 11 months ago (2012-07-18 00:17:05 UTC) #3
Graham Percival
6 years, 11 months ago (2012-07-19 11:14:48 UTC) #4
http://codereview.appspot.com/6398055/diff/1/Documentation/de/notation/repeat...
File Documentation/de/notation/repeats.itely (right):

http://codereview.appspot.com/6398055/diff/1/Documentation/de/notation/repeat...
Documentation/de/notation/repeats.itely:245: @cindex ndex \inStaffSegno
what's an ndex?

http://codereview.appspot.com/6398055/diff/1/Documentation/notation/rhythms.i...
File Documentation/notation/rhythms.itely (right):

http://codereview.appspot.com/6398055/diff/1/Documentation/notation/rhythms.i...
Documentation/notation/rhythms.itely:2676: Additionally there is an
@code{\inStaffSegno} command which
I agree with David's disagreement.  "an @code{\inStaffSegno}" is correct.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b