code review 6350086: cmd/godoc: delete -path flag

cmd/godoc: delete -path flag

Fixes issue 3453.

[dave_cheney.net, 2012-07-06 12:57:34]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[gri, 2012-07-09 17:55:37]

http://codereview.appspot.com/6350086/diff/5001/src/cmd/godoc/doc.go
File src/cmd/godoc/doc.go (right):

http://codereview.appspot.com/6350086/diff/5001/src/cmd/godoc/doc.go#newcode89
src/cmd/godoc/doc.go:89: Additional directories may be specified via the -path
flag which accepts a list
This section needs to be updated as well

[dave_cheney.net, 2012-07-10 08:46:10]

Hello golang-dev@googlegroups.com, gri@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[dave_cheney.net, 2012-07-10 08:47:01]

Thank you for comments Robert. Please take another look.

http://codereview.appspot.com/6350086/diff/5001/src/cmd/godoc/doc.go
File src/cmd/godoc/doc.go (right):

http://codereview.appspot.com/6350086/diff/5001/src/cmd/godoc/doc.go#newcode89
src/cmd/godoc/doc.go:89: Additional directories may be specified via the -path
flag which accepts a list
On 2012/07/09 17:55:37, gri wrote:
> This section needs to be updated as well

Done.

[gri, 2012-07-10 16:57:24]

LGTM.

Thanks.

We are having some internal discussions re: the -path flag; I will wait with the
submission until we have resolved this.

[jmhodges, 2012-07-10 17:16:06]

It would be cool if those discussions were public if they are
affecting the submission of code to Go.

[bradfitz, 2012-07-10 17:22:11]

I think Robert just meant a quick in-person conversation we were having
yesterday at lunch about whether this flag is part of the "Go1 API" or not.

I didn't see any internal thread about this.  Our internal discussions are
just about Google Go libraries, not standard library stuff.


On Tue, Jul 10, 2012 at 10:15 AM, Jeff Hodges <jeff@somethingsimilar.com>wrote:

> It would be cool if those discussions were public if they are
> affecting the submission of code to Go.
>

[jmhodges, 2012-07-10 21:45:35]

Ah, I see. Thanks for the details!

On Tue, Jul 10, 2012 at 10:22 AM, Brad Fitzpatrick
<bradfitz@golang.org<javascript:;>>
wrote:
> think Robert just meant a quick in-person conversation we were having
> yesterday at lunch about whether this flag is part of the "Go1 API" or
not.
>
> I didn't see any internal thread about this.  Our internal discussions are
> just about Google Go libraries, not standard library stuff

[dave_cheney.net, 2012-07-10 21:56:32]

> We are having some internal discussions re: the -path flag; I will wait with
the
> submission until we have resolved this.

Thanks Robert. I will wait for further word from you if -path is a component of
the Go1 contract.

[gri, 2012-07-25 17:50:01]

*** Submitted as http://code.google.com/p/go/source/detail?r=bfe5e28a0484 ***

cmd/godoc: delete -path flag

Fixes issue 3453.

R=golang-dev, gri, jeff, bradfitz
CC=golang-dev
http://codereview.appspot.com/6350086

Committer: Robert Griesemer <gri@golang.org>