Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 6350086: code review 6350086: cmd/godoc: delete -path flag (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by dfc
Modified:
2 years, 9 months ago
Reviewers:
CC:
golang-dev, gri, jmhodges, bradfitz
Visibility:
Public.

Description

cmd/godoc: delete -path flag Fixes issue 3453.

Patch Set 1 #

Patch Set 2 : diff -r 080799c3785f https://code.google.com/p/go #

Patch Set 3 : diff -r 080799c3785f https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r b90fb8c2bb6f https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 695f65745351 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -27 lines) Patch
M src/cmd/godoc/doc.go View 1 2 3 4 2 chunks +2 lines, -16 lines 0 comments Download
M src/cmd/godoc/godoc.go View 1 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
2 years, 10 months ago (2012-07-06 12:57:34 UTC) #1
gri
http://codereview.appspot.com/6350086/diff/5001/src/cmd/godoc/doc.go File src/cmd/godoc/doc.go (right): http://codereview.appspot.com/6350086/diff/5001/src/cmd/godoc/doc.go#newcode89 src/cmd/godoc/doc.go:89: Additional directories may be specified via the -path flag ...
2 years, 10 months ago (2012-07-09 17:55:37 UTC) #2
dfc
Hello golang-dev@googlegroups.com, gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
2 years, 10 months ago (2012-07-10 08:46:10 UTC) #3
dfc
Thank you for comments Robert. Please take another look. http://codereview.appspot.com/6350086/diff/5001/src/cmd/godoc/doc.go File src/cmd/godoc/doc.go (right): http://codereview.appspot.com/6350086/diff/5001/src/cmd/godoc/doc.go#newcode89 src/cmd/godoc/doc.go:89: ...
2 years, 10 months ago (2012-07-10 08:47:01 UTC) #4
gri
LGTM. Thanks. We are having some internal discussions re: the -path flag; I will wait ...
2 years, 10 months ago (2012-07-10 16:57:24 UTC) #5
jmhodges
It would be cool if those discussions were public if they are affecting the submission ...
2 years, 10 months ago (2012-07-10 17:16:06 UTC) #6
bradfitz
I think Robert just meant a quick in-person conversation we were having yesterday at lunch ...
2 years, 10 months ago (2012-07-10 17:22:11 UTC) #7
jmhodges
Ah, I see. Thanks for the details! On Tue, Jul 10, 2012 at 10:22 AM, ...
2 years, 10 months ago (2012-07-10 21:45:35 UTC) #8
dfc
> We are having some internal discussions re: the -path flag; I will wait with ...
2 years, 10 months ago (2012-07-10 21:56:32 UTC) #9
gri
2 years, 10 months ago (2012-07-25 17:50:01 UTC) #10
*** Submitted as http://code.google.com/p/go/source/detail?r=bfe5e28a0484 ***

cmd/godoc: delete -path flag

Fixes issue 3453.

R=golang-dev, gri, jeff, bradfitz
CC=golang-dev
http://codereview.appspot.com/6350086

Committer: Robert Griesemer <gri@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e6eadc5