Issue 6349097: environs: add methods for opening and closing ports.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6349097: environs: add methods for opening and closing ports.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by rog

Modified:
11 years, 9 months ago

Reviewers:
dave, mp+114643, niemeyer

Visibility:
Public.

Description

environs: add methods for opening and closing ports. Also add a dummy implementation, and clean up dummy op send semantics slightly. https://code.launchpad.net/~rogpeppe/juju-core/environs-port-management/+merge/114643 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: add methods for opening and closing ports. #

Total comments: 2

Patch Set 3 : environs: add methods for opening and closing ports. #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+220 lines, -24 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/dummy/environs.go	View	1 2	8 chunks	+91 lines, -20 lines	0 comments	Download
M	environs/ec2/ec2.go	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	environs/ec2/live_test.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	environs/ec2/local_test.go	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	environs/interface.go	View	1	3 chunks	+16 lines, -4 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	1	2 chunks	+87 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

LGTM, but please consider this: https://codereview.appspot.com/6349097/diff/9/environs/dummy/environs.go File environs/dummy/environs.go (right): https://codereview.appspot.com/6349097/diff/9/environs/dummy/environs.go#newcode454 environs/dummy/environs.go:454: inst.state.ops <- OpOpenPorts{ I ...

11 years, 9 months ago (2012-07-12 14:59:04 UTC) #3

rog

*** Submitted: environs: add methods for opening and closing ports. Also add a dummy implementation, ...

11 years, 9 months ago (2012-07-12 15:21:52 UTC) #4

LGTM.

Expand All Messages | Collapse All Messages