Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(291)

Issue 6349078: JAVA/JS: Metadata updates (v4.9.1) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by davinci_google
Modified:
1 year, 9 months ago
Reviewers:
lararennie, Shaopeng
Base URL:
http://libphonenumber.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 13

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+614 lines, -442 lines) Patch
A java/geocoder/src/com/google/i18n/phonenumbers/geocoding/data/234_en View Binary file 0 comments Download
M java/geocoder/src/com/google/i18n/phonenumbers/geocoding/data/54_en View 1 1 chunk +16 lines, -17 lines 0 comments Download
M java/geocoder/src/com/google/i18n/phonenumbers/geocoding/data/54_es View Binary file 0 comments Download
M java/geocoder/src/com/google/i18n/phonenumbers/geocoding/data/81_en View 1 1 chunk +59 lines, -69 lines 0 comments Download
M java/geocoder/src/com/google/i18n/phonenumbers/geocoding/data/config View Binary file 0 comments Download
M java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_882 View Binary file 0 comments Download
M java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_AR View Binary file 0 comments Download
M java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_BA View Binary file 0 comments Download
M java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_BF View Binary file 0 comments Download
M java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_CR View Binary file 0 comments Download
M java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_DE View Binary file 0 comments Download
M java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_EC View Binary file 0 comments Download
M java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_ES View Binary file 0 comments Download
M java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_MK View Binary file 0 comments Download
M java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_NC View Binary file 0 comments Download
M java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_NG View Binary file 0 comments Download
M java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_PF View Binary file 0 comments Download
M java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_SB View Binary file 0 comments Download
M java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_UZ View Binary file 0 comments Download
M java/release_notes.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M javascript/i18n/phonenumbers/metadata.js View 20 chunks +43 lines, -38 lines 0 comments Download
M javascript/i18n/phonenumbers/metadatalite.js View 18 chunks +38 lines, -33 lines 0 comments Download
M resources/PhoneNumberMetaData.xml View 1 39 chunks +198 lines, -89 lines 0 comments Download
A resources/geocoding/en/234.txt View 1 chunk +79 lines, -0 lines 0 comments Download
M resources/geocoding/en/54.txt View 1 7 chunks +0 lines, -12 lines 0 comments Download
M resources/geocoding/en/81.txt View 1 40 chunks +173 lines, -172 lines 0 comments Download
M resources/geocoding/es/54.txt View 1 8 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 7
davinci_google
1 year, 9 months ago #1
lararennie
LGTM http://codereview.appspot.com/6349078/diff/1/java/release_notes.txt File java/release_notes.txt (right): http://codereview.appspot.com/6349078/diff/1/java/release_notes.txt#newcode3 java/release_notes.txt:3: - AR, BA, BF, CR, DE, EC, ES, ...
1 year, 9 months ago #2
Shaopeng
Thanks for the change, David! Since most of my comments are about things that should ...
1 year, 9 months ago #3
davinci_google
http://codereview.appspot.com/6349078/diff/1/java/release_notes.txt File java/release_notes.txt (right): http://codereview.appspot.com/6349078/diff/1/java/release_notes.txt#newcode3 java/release_notes.txt:3: - AR, BA, BF, CR, DE, EC, ES, KZ, ...
1 year, 9 months ago #4
davinci_google
http://codereview.appspot.com/6349078/diff/1/resources/geocoding/en/81.txt File resources/geocoding/en/81.txt (right): http://codereview.appspot.com/6349078/diff/1/resources/geocoding/en/81.txt#newcode16 resources/geocoding/en/81.txt:16: # ja/81.txt and translated with Freebase. On 2012/07/06 10:32:51, ...
1 year, 9 months ago #5
davinci_google
1 year, 9 months ago #6
Shaopeng
1 year, 9 months ago #7
On 2012/07/06 12:52:53, davinci_google wrote:

the Js metadata needs to be regenerated, otherwise LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5