Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(712)

Issue 6344046: code review 6344046: net/http: added ParseTime function. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by pah
Modified:
11 years, 1 month ago
Reviewers:
CC:
golang-dev, dfc, rsc, r, bradfitz
Visibility:
Public.

Description

net/http: added ParseTime function. Parses a time header value into a time.Time according to rfc2616 sec 3.3.

Patch Set 1 #

Patch Set 2 : diff -r d8bd45866999 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6c2875dfccfe https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6c2875dfccfe https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 6c2875dfccfe https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 6 : diff -r bf1b1141ccbf https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M src/pkg/net/http/header.go View 1 2 3 4 5 2 chunks +20 lines, -0 lines 0 comments Download
M src/pkg/net/http/header_test.go View 1 2 3 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 15
pah
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 9 months ago (2012-06-27 19:51:31 UTC) #1
dfc
What about other datetime style headers like Expires ?
11 years, 9 months ago (2012-06-28 06:16:41 UTC) #2
pah
Good point. I hadn't needed Expires yet, but I do today. :-) It seems most ...
11 years, 9 months ago (2012-06-28 16:35:16 UTC) #3
pah
Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 9 months ago (2012-06-28 22:26:59 UTC) #4
bradfitz
I'm fine with this (especially given http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.3), but I defer to Rob or Russ about ...
11 years, 7 months ago (2012-08-06 03:51:22 UTC) #5
bradfitz
... although I just noticed the CL description is no longer accurate. On Mon, Aug ...
11 years, 7 months ago (2012-08-06 03:53:30 UTC) #6
rsc
Please fix CL description (hg change).
11 years, 7 months ago (2012-08-06 19:49:19 UTC) #7
pah
Hello golang-dev@googlegroups.com, dave@cheney.net, rsc@golang.org, r@golang.org (cc: bradfitz@golang.org, golang-dev@googlegroups.com), Please take another look.
11 years, 7 months ago (2012-08-06 20:05:43 UTC) #8
rsc
http://codereview.appspot.com/6344046/diff/11002/src/pkg/net/http/header.go File src/pkg/net/http/header.go (right): http://codereview.appspot.com/6344046/diff/11002/src/pkg/net/http/header.go#newcode57 src/pkg/net/http/header.go:57: // ParseTime tries parsing a header using each of ...
11 years, 7 months ago (2012-08-06 20:27:02 UTC) #9
pah
Hello golang-dev@googlegroups.com, dave@cheney.net, rsc@golang.org, r@golang.org (cc: bradfitz@golang.org, golang-dev@googlegroups.com), Please take another look.
11 years, 7 months ago (2012-08-06 20:45:55 UTC) #10
rsc
LGTM
11 years, 7 months ago (2012-08-31 19:57:18 UTC) #11
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=c5391c55fb2f *** net/http: added ParseTime function. Parses a time header value into ...
11 years, 7 months ago (2012-08-31 22:10:22 UTC) #12
pah
*** Abandoned ***
11 years, 1 month ago (2013-02-04 20:10:43 UTC) #13
pah
Sorry for the noise. I was trying to create my second CL and when running ...
11 years, 1 month ago (2013-02-04 20:42:54 UTC) #14
dfc
11 years, 1 month ago (2013-02-05 01:30:50 UTC) #15
hg -D 6344046

On Tue, Feb 5, 2013 at 7:42 AM, Patrick Higgins
<patrick.allen.higgins@gmail.com> wrote:
> Sorry for the noise. I was trying to create my second CL and when running
> "hg sync" I was given this message:
>
> Removing unmodified files from CL 6344046:
> src/pkg/net/http/header.go
> src/pkg/net/http/header_test.go
> CL 6344046 has no files; delete (abandon) with hg change -d 6344046
>
> I followed the instructions to run "hg change -d 6344046" but that doesn't
> seem like what I really wanted to do.
>
> What should I have done instead?
>
>
> On Mon, Feb 4, 2013 at 1:10 PM, <patrick.allen.higgins@gmail.com> wrote:
>>
>> *** Abandoned ***
>>
>> https://codereview.appspot.com/6344046/
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b