Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3356)

Issue 6336054: code review 6336054: runtime: remove memset/memclr shim (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by dfc
Modified:
1 year, 10 months ago
Reviewers:
CC:
minux, rsc, golang-dev
Visibility:
Public.

Description

runtime: remove memset/memclr shim

This CL resolves https://codereview.appspot.com/6300043/#msg3
by renaming memset_arm.s to memclr_arm.s and merging the function
of the same name from asm_arm.s.

Patch Set 1 #

Patch Set 2 : diff -r 631ba1cdd9fa https://code.google.com/p/go #

Patch Set 3 : diff -r 631ba1cdd9fa https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 631ba1cdd9fa https://code.google.com/p/go #

Patch Set 5 : diff -r 631ba1cdd9fa https://code.google.com/p/go #

Patch Set 6 : diff -r 631ba1cdd9fa https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M src/pkg/runtime/asm_arm.s View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/pkg/runtime/memclr_arm.s View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6
dfc
Hello minux.ma@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
1 year, 10 months ago #1
dfc
No significant performance improvement (or regression) benchmark old ns/op new ns/op delta BenchmarkBinaryTree17 37223327000 36789917000 ...
1 year, 10 months ago #2
rsc
LGTM after reverting the copyright notice change http://codereview.appspot.com/6336054/diff/1002/src/pkg/runtime/memclr_arm.s File src/pkg/runtime/memclr_arm.s (right): http://codereview.appspot.com/6336054/diff/1002/src/pkg/runtime/memclr_arm.s#newcode1 src/pkg/runtime/memclr_arm.s:1: // Derived ...
1 year, 10 months ago #3
dfc
Thanks for your comments, the diff is now very small. http://codereview.appspot.com/6336054/diff/1002/src/pkg/runtime/memclr_arm.s File src/pkg/runtime/memclr_arm.s (right): http://codereview.appspot.com/6336054/diff/1002/src/pkg/runtime/memclr_arm.s#newcode1 ...
1 year, 10 months ago #4
dfc
Hello minux.ma@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
1 year, 10 months ago #5
dfc
1 year, 10 months ago #6
*** Submitted as http://code.google.com/p/go/source/detail?r=4b823a31b17d ***

runtime: remove memset/memclr shim

This CL resolves https://codereview.appspot.com/6300043/#msg3
by renaming memset_arm.s to memclr_arm.s and merging the function
of the same name from asm_arm.s.

R=minux.ma, rsc
CC=golang-dev
http://codereview.appspot.com/6336054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5