Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(584)

Issue 6305055: code review 6305055: test/bench/go1: add go/parser benchmark (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by dfc
Modified:
1 year, 10 months ago
Reviewers:
CC:
golang-dev, minux, rsc
Visibility:
Public.

Description

test/bench/go1: add go/parser benchmark

As discussed in

https://groups.google.com/d/msg/golang-dev/Na9XE6mcQyY/zbeBI7R-vnoJ

Here is a static copy of the go/parser benchmark. I ended up using
fancy encodings because the original parser.go had a number of `s
scattered throughout which made it hard to embed the source directly.

Curiously on my laptop this benchmark always scores roughly 10% higher
than the standalone benchmark. This may be down to the generation of
the fasta data set triggering the cpu governor to raise the cpu speed.
However the benchmark is consistent with itself across multiple runs.

Patch Set 1 #

Patch Set 2 : diff -r 9b455eb64690 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9b455eb64690 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2d505463ad5b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -0 lines) Patch
A test/bench/go1/parser_test.go View 1 1 chunk +43 lines, -0 lines 0 comments Download
A test/bench/go1/parserdata_test.go View 1 1 chunk +245 lines, -0 lines 0 comments Download

Messages

Total messages: 5
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
1 year, 10 months ago #1
minux
have you tried to use the userspace cpu governor and set cpu speed manually? on ...
1 year, 10 months ago #2
dfc
On 2012/06/06 13:07:23, minux wrote: > have you tried to use the userspace cpu governor ...
1 year, 10 months ago #3
rsc
LGTM
1 year, 10 months ago #4
dfc
1 year, 10 months ago #5
*** Submitted as http://code.google.com/p/go/source/detail?r=d5d55e8e2f51 ***

test/bench/go1: add go/parser benchmark

As discussed in

https://groups.google.com/d/msg/golang-dev/Na9XE6mcQyY/zbeBI7R-vnoJ

Here is a static copy of the go/parser benchmark. I ended up using
fancy encodings because the original parser.go had a number of `s
scattered throughout which made it hard to embed the source directly.

Curiously on my laptop this benchmark always scores roughly 10% higher
than the standalone benchmark. This may be down to the generation of
the fasta data set triggering the cpu governor to raise the cpu speed.
However the benchmark is consistent with itself across multiple runs.

R=golang-dev, minux.ma, rsc
CC=golang-dev
http://codereview.appspot.com/6305055
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5