environs/dummy: enhance start/stop operations

environs/dummy: enhance start/stop operations

This is an alternate proposal to enhance dummy to return
the actual environ.Instance objects created during 
Start/StopInstance operations.

This would be used in the PA tests to double check that 
m, err := s.st.AddMachine(n); m.InstanceId matches the 
Instance.Id() provided by dummy.

https://code.launchpad.net/~dave-cheney/juju-core/go-environs-dummy-operation/+merge/111143

(do not edit description out of merge proposal)

[dave_cheney.net, 2012-06-20 05:14:58]

Please take a look.

[dave_cheney.net, 2012-06-20 12:36:00]

Please take a look.

[niemeyer, 2012-06-20 20:16:36]

Happy with this, thanks.

Just a couple of trivials.

https://codereview.appspot.com/6304104/diff/5001/environs/dummy/environs.go
File environs/dummy/environs.go (right):

https://codereview.appspot.com/6304104/diff/5001/environs/dummy/environs.go#n...
environs/dummy/environs.go:72: func (k OperationKind) Kind() OperationKind {
return k }
This trick is only useful if we can use OperationKind as an Operation. Since we
can't, I suggest moving it to the operation type and naming the field as "kind",
in a more traditional form.

https://codereview.appspot.com/6304104/diff/5001/environs/dummy/environs.go#n...
environs/dummy/environs.go:348: // StartOperation represents a StartInstance
operation on the dummy provider.
s/StartOperation/StartInstanceOp/

env.StartInstance() => OpStartInstance => StartInstanceOp

Please review docs and methods below too.

[niemeyer, 2012-06-20 20:16:59]

LGTM with these sorted.

[dave_cheney.net, 2012-06-21 05:17:29]

Please take a look.

https://codereview.appspot.com/6304104/diff/5001/environs/dummy/environs.go
File environs/dummy/environs.go (right):

https://codereview.appspot.com/6304104/diff/5001/environs/dummy/environs.go#n...
environs/dummy/environs.go:72: func (k OperationKind) Kind() OperationKind {
return k }
On 2012/06/20 20:16:36, niemeyer wrote:
> This trick is only useful if we can use OperationKind as an Operation. Since
we
> can't, I suggest moving it to the operation type and naming the field as
"kind",
> in a more traditional form.

Yup, it was all going smoothly until I found some tests that used the Env()
value.

[niemeyer, 2012-06-21 16:50:44]

LGTM. I'm submitting as we've just agreed online to move the branch location to
lp.net/juju-core, and submitting now I can save you some trouble.

[niemeyer, 2012-06-21 18:14:36]

Roger mentioned on IRC that you guys had agreed on something else for this?

<rog> niemeyer: re: https://codereview.appspot.com/6304104/ i think we might
have decided to go with a different, slightly simpler approach.
<niemeyer> rog: The approach there looks pretty straightforward and clean to me
<rog> niemeyer: this was my suggestion to dave this morning:
http://paste.ubuntu.com/1052155/
<niemeyer> rog: I mentioned it could stay simpler, but I also don't see an issue
with doing it now, given Dave actually wrote it
<rog> niemeyer: which he seemed to quite like
<rog> niemeyer: in some similar form anyway
<niemeyer> rog: That sounds fine too
<rog> niemeyer: it means we can get rid of operationKinds, the string table etc

?

Not submitting. Please let me know how you want to push this forward.

[dave_cheney.net, 2012-06-22 07:16:22]

Please take a look.

[niemeyer, 2012-06-22 14:26:39]

LGTM, thanks Dave.

The genericOperation should be exported, but Roger will handle that in a follow
up.

[niemeyer, 2012-06-22 14:56:48]

*** Submitted:

environs/dummy: enhance start/stop operations

This is an alternate proposal to enhance dummy to return
the actual environ.Instance objects created during 
Start/StopInstance operations.

This would be used in the PA tests to double check that 
m, err := s.st.AddMachine(n); m.InstanceId matches the 
Instance.Id() provided by dummy.

R=niemeyer
CC=
https://codereview.appspot.com/6304104

[niemeyer, 2012-06-22 14:57:54]

Submitted this as Roger is blocked on another branch.