Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 6300043: code review 6300043: runtime: avoid r9/r10 during memset (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by dfc
Modified:
2 years, 9 months ago
Reviewers:
CC:
golang-dev, rsc, minux1
Visibility:
Public.

Description

runtime: avoid r9/r10 during memset Partially fixes issue 3718.

Patch Set 1 #

Patch Set 2 : diff -r 4fdf6aa4f602 https://code.google.com/p/go #

Patch Set 3 : diff -r 7ba52afb6a1b https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 6ca4825bc867 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -33 lines) Patch
M src/pkg/runtime/asm_arm.s View 1 1 chunk +3 lines, -9 lines 0 comments Download
M src/pkg/runtime/memset_arm.s View 1 4 chunks +21 lines, -24 lines 0 comments Download

Messages

Total messages: 5
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
2 years, 9 months ago (2012-06-14 20:47:09 UTC) #1
rsc
LGTM
2 years, 9 months ago (2012-06-19 03:45:36 UTC) #2
minux1
http://codereview.appspot.com/6300043/diff/2002/src/pkg/runtime/memset_arm.s File src/pkg/runtime/memset_arm.s (right): http://codereview.appspot.com/6300043/diff/2002/src/pkg/runtime/memset_arm.s#newcode31 src/pkg/runtime/memset_arm.s:31: TEXT runtime·memset(SB), $0 runtime.memset doesn't follow our function call ...
2 years, 9 months ago (2012-06-19 16:42:20 UTC) #3
dfc
Thank you for your comments, PTAL. http://codereview.appspot.com/6300043/diff/2002/src/pkg/runtime/memset_arm.s File src/pkg/runtime/memset_arm.s (right): http://codereview.appspot.com/6300043/diff/2002/src/pkg/runtime/memset_arm.s#newcode31 src/pkg/runtime/memset_arm.s:31: TEXT runtime·memset(SB), $0 ...
2 years, 9 months ago (2012-06-19 21:25:23 UTC) #4
dfc
2 years, 9 months ago (2012-06-24 22:00:06 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=572efb136b1a ***

runtime: avoid r9/r10 during memset

Partially fixes issue 3718.

R=golang-dev, rsc, minux.ma
CC=golang-dev
http://codereview.appspot.com/6300043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e6eadc5