Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(438)

Issue 6300043: code review 6300043: runtime: avoid r9/r10 during memset (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by dfc
Modified:
1 year, 9 months ago
Reviewers:
CC:
golang-dev, rsc, minux
Visibility:
Public.

Description

runtime: avoid r9/r10 during memset

Partially fixes issue 3718.

Patch Set 1 #

Patch Set 2 : diff -r 4fdf6aa4f602 https://code.google.com/p/go #

Patch Set 3 : diff -r 7ba52afb6a1b https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 6ca4825bc867 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -33 lines) Patch
M src/pkg/runtime/asm_arm.s View 1 1 chunk +3 lines, -9 lines 0 comments Download
M src/pkg/runtime/memset_arm.s View 1 4 chunks +21 lines, -24 lines 0 comments Download

Messages

Total messages: 5
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
1 year, 10 months ago #1
rsc
LGTM
1 year, 10 months ago #2
minux
http://codereview.appspot.com/6300043/diff/2002/src/pkg/runtime/memset_arm.s File src/pkg/runtime/memset_arm.s (right): http://codereview.appspot.com/6300043/diff/2002/src/pkg/runtime/memset_arm.s#newcode31 src/pkg/runtime/memset_arm.s:31: TEXT runtime·memset(SB), $0 runtime.memset doesn't follow our function call ...
1 year, 10 months ago #3
dfc
Thank you for your comments, PTAL. http://codereview.appspot.com/6300043/diff/2002/src/pkg/runtime/memset_arm.s File src/pkg/runtime/memset_arm.s (right): http://codereview.appspot.com/6300043/diff/2002/src/pkg/runtime/memset_arm.s#newcode31 src/pkg/runtime/memset_arm.s:31: TEXT runtime·memset(SB), $0 ...
1 year, 10 months ago #4
dfc
1 year, 9 months ago #5
*** Submitted as http://code.google.com/p/go/source/detail?r=572efb136b1a ***

runtime: avoid r9/r10 during memset

Partially fixes issue 3718.

R=golang-dev, rsc, minux.ma
CC=golang-dev
http://codereview.appspot.com/6300043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5