Issue 6261058: add charm.InferRepository

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6261058: add charm.InferRepository

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by fwereade

Modified:
11 years, 10 months ago

Reviewers:
mp+108337

Visibility:
Public.

Description

add charm.InferRepository https://code.launchpad.net/~fwereade/juju/go-charm-resolve/+merge/108337 (do not edit description out of merge proposal)

Patch Set 2 : add charm.InferRepository #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -1 line)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charm/charm.go	View	1	2 chunks	+26 lines, -1 line	0 comments	Download
M	charm/charm_test.go	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6261058/diff/1/charm/charm.go File charm/charm.go (right): https://codereview.appspot.com/6261058/diff/1/charm/charm.go#newcode32 charm/charm.go:32: // a charm matching that URL. // InferRepository ...

11 years, 10 months ago (2012-06-01 13:32:33 UTC) #2

fwereade

11 years, 10 months ago (2012-06-01 14:32:33 UTC) #3

*** Submitted:

add charm.InferRepository

R=niemeyer
CC=
https://codereview.appspot.com/6261058

https://codereview.appspot.com/6261058/diff/1/charm/charm.go
File charm/charm.go (right):

https://codereview.appspot.com/6261058/diff/1/charm/charm.go#newcode32
charm/charm.go:32: // a charm matching that URL.
On 2012/06/01 13:32:34, niemeyer wrote:
> // InferRepository returns a charm repository and URL inferred from the
provided
> // parameters. charmAlias may hold an exact charm URL, or an alias in a
> // format supported by InferURL.

Done.

https://codereview.appspot.com/6261058/diff/1/charm/charm.go#newcode33
charm/charm.go:33: func Resolve(name, repoPath, defaultSeries string) (repo
Repository, curl *URL, err error) {
On 2012/06/01 13:32:34, niemeyer wrote:
> This is InferURL + repository. I suggest this signature:
> 
> func InferRepository(charmAlias, defaultSeries, localRepoPath string) (repo
> Repository, curl *URL, err error)
> 
> (note the parameter ordering matching InferURL)

Done.

https://codereview.appspot.com/6261058/diff/1/charm/charm.go#newcode41
charm/charm.go:41: repo = &LocalRepository{repoPath}
On 2012/06/01 13:32:34, niemeyer wrote:
> Should we support the case where localRepoPath is ""? Not sure about how the
> call site for this will look like.

I think an explicit error here is a good idea. Done.

Expand All Messages | Collapse All Messages