code review 6260047: cmd/go: add -ccflags

cmd/go: add -ccflags

Add -ccflags to pass arguments to {5,6,8}c
similar to -gcflags for {5,6,8}g.

[dfc, 2012-05-29 09:47:36]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rsc1, 2012-05-29 13:20:37]

Why?

[dfc, 2012-05-30 01:35:43]

I wanted to add it to make it easier to pass -S to cc when compiling .c files in
pkg/runtime. It is simpler to let the go tool construct the correct include
path.

As this is mainly a debugging tool, and .c files are only present in
pkg/runtime, this might be too specialised to be of value.

[rsc1, 2012-05-30 02:03:55]

My only worry is that 'ccflags' sounds like the conventional $CCFLAGS,
which this is not. But it's probably fine.

[rsc1, 2012-05-30 02:04:09]

Actually I guess that's CFLAGS.  Good enough.

[rsc1, 2012-05-30 02:05:39]

Please move -ccflags up above -compiler, to keep the with-arguments
section of the list sorted.
Otherwise looks good.

[dfc, 2012-05-30 02:18:36]

PTAL.

[dfc, 2012-05-30 23:10:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=3524a4743246 ***

cmd/go: add -ccflags

Add -ccflags to pass arguments to {5,6,8}c
similar to -gcflags for {5,6,8}g.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6260047

[rsc1, 2012-05-31 00:30:01]

LGTM

Please wait for an LGTM before submitting.  Sorry for the delay.

[dfc, 2012-05-31 01:01:25]

This was my mistake, I mistook your previous comment.

On Thu, May 31, 2012 at 10:29 AM, Russ Cox <rsc@google.com> wrote:
> LGTM
>
> Please wait for an LGTM before submitting.  Sorry for the delay.