Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(624)

Issue 6260047: code review 6260047: cmd/go: add -ccflags (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by dfc
Modified:
1 year, 10 months ago
Reviewers:
CC:
golang-dev, rsc1
Visibility:
Public.

Description

cmd/go: add -ccflags

Add -ccflags to pass arguments to {5,6,8}c
similar to -gcflags for {5,6,8}g.

Patch Set 1 #

Patch Set 2 : diff -r 40632db23c46 https://code.google.com/p/go #

Patch Set 3 : diff -r 40632db23c46 https://code.google.com/p/go #

Patch Set 4 : diff -r 21b2ae0204b0 https://code.google.com/p/go #

Patch Set 5 : diff -r 31c459151a78 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/cmd/go/build.go View 1 2 3 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
1 year, 10 months ago #1
rsc1
Why?
1 year, 10 months ago #2
dfc
I wanted to add it to make it easier to pass -S to cc when ...
1 year, 10 months ago #3
rsc1
My only worry is that 'ccflags' sounds like the conventional $CCFLAGS, which this is not. ...
1 year, 10 months ago #4
rsc1
Actually I guess that's CFLAGS. Good enough.
1 year, 10 months ago #5
rsc1
Please move -ccflags up above -compiler, to keep the with-arguments section of the list sorted. ...
1 year, 10 months ago #6
dfc
PTAL.
1 year, 10 months ago #7
dfc
*** Submitted as http://code.google.com/p/go/source/detail?r=3524a4743246 *** cmd/go: add -ccflags Add -ccflags to pass arguments to {5,6,8}c ...
1 year, 10 months ago #8
rsc1
LGTM Please wait for an LGTM before submitting. Sorry for the delay.
1 year, 10 months ago #9
dfc
1 year, 10 months ago #10
This was my mistake, I mistook your previous comment.

On Thu, May 31, 2012 at 10:29 AM, Russ Cox <rsc@google.com> wrote:
> LGTM
>
> Please wait for an LGTM before submitting.  Sorry for the delay.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5