Issue 6257043: environs/ec2: regenerate image data

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6257043: environs/ec2: regenerate image data

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by rog

Modified:
11 years, 11 months ago

Reviewers:
mp+107230

Visibility:
Public.

Description

environs/ec2: regenerate image data There is no code being written here, just adding precise and quantal to image_test.go and a run of gotest -regenerate-images. This means we have a set of test images that can satisfy the actual constraints of the current environment. https://code.launchpad.net/~rogpeppe/juju/go-ec2-regenerate-images/+merge/107230 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/ec2: regenerate image data #

Patch Set 3 : environs/ec2: regenerate image data #

Patch Set 4 : environs/ec2: regenerate image data #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+327 lines, -156 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/ec2/image_test.go	View	1 2	6 chunks	+6 lines, -6 lines	0 comments	Download
M	environs/ec2/images/query/natty/desktop/daily.current.txt	View	1 2	1 chunk	+29 lines, -25 lines	0 comments	Download
M	environs/ec2/images/query/natty/server/daily.current.txt	View	1 2	1 chunk	+29 lines, -25 lines	0 comments	Download
M	environs/ec2/images/query/natty/server/released.current.txt	View	1 2	1 chunk	+29 lines, -25 lines	0 comments	Download
M	environs/ec2/images/query/oneiric/desktop/daily.current.txt	View	1 2	1 chunk	+29 lines, -25 lines	0 comments	Download
M	environs/ec2/images/query/oneiric/server/daily.current.txt	View	1 2	1 chunk	+29 lines, -25 lines	0 comments	Download
M	environs/ec2/images/query/oneiric/server/released.current.txt	View	1 2	1 chunk	+29 lines, -25 lines	0 comments	Download
A	environs/ec2/images/query/precise/desktop/daily.current.txt	View	1 2	1 chunk	+29 lines, -0 lines	0 comments	Download
A	environs/ec2/images/query/precise/server/daily.current.txt	View	1 2	1 chunk	+29 lines, -0 lines	0 comments	Download
A	environs/ec2/images/query/precise/server/released.current.txt	View	1 2	1 chunk	+29 lines, -0 lines	0 comments	Download
A	environs/ec2/images/query/quantal/desktop/daily.current.txt	View	1 2	1 chunk	+29 lines, -0 lines	0 comments	Download
A	environs/ec2/images/query/quantal/server/daily.current.txt	View	1 2	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rog

11 years, 11 months ago (2012-05-24 17:11:50 UTC) #5

*** Submitted:

environs/ec2: regenerate image data

There is no code being written here, just
adding precise and quantal to image_test.go and
a run of gotest -regenerate-images.

This means we have a set of test images that
can satisfy the actual constraints of the
current environment.

R=niemeyer
CC=
https://codereview.appspot.com/6257043

Expand All Messages | Collapse All Messages