add juju.Conn.Close

add juju.Conn.Close

I'm not sure that there's an especially clean way to enforce the "don't close
conn state directly" advice. If someone can think of one, please let me know,
so I can fix that now :).

https://code.launchpad.net/~fwereade/juju/go-close-conn/+merge/108309

(do not edit description out of merge proposal)

[fwereade, 2012-06-01 09:17:52]

Please take a look.

[niemeyer, 2012-06-01 12:33:02]

LGTM

https://codereview.appspot.com/6250083/diff/1/juju/conn.go
File juju/conn.go (right):

https://codereview.appspot.com/6250083/diff/1/juju/conn.go#newcode49
juju/conn.go:49: // Conn itself is no longer required, the Conn itself should be
closed.
I think we can be more terse:

// State returns the environment State associated with c.
// Closing the obtained state will have undefined
// consequences. Close c itself instead.

https://codereview.appspot.com/6250083/diff/1/juju/conn.go#newcode67
juju/conn.go:67: // Close closes the conn's shared State.
// Close terminates the communication with the environment
// and releases any associated resources.

[fwereade, 2012-06-01 12:50:01]

*** Submitted:

add juju.Conn.Close

I'm not sure that there's an especially clean way to enforce the "don't close
conn state directly" advice. If someone can think of one, please let me know,
so I can fix that now :).

R=
CC=
https://codereview.appspot.com/6250083

https://codereview.appspot.com/6250083/diff/1/juju/conn.go
File juju/conn.go (right):

https://codereview.appspot.com/6250083/diff/1/juju/conn.go#newcode49
juju/conn.go:49: // Conn itself is no longer required, the Conn itself should be
closed.
On 2012/06/01 12:33:02, niemeyer wrote:
> I think we can be more terse:
> 
> // State returns the environment State associated with c.
> // Closing the obtained state will have undefined
> // consequences. Close c itself instead.

Done.

https://codereview.appspot.com/6250083/diff/1/juju/conn.go#newcode67
juju/conn.go:67: // Close closes the conn's shared State.
On 2012/06/01 12:33:02, niemeyer wrote:
> // Close terminates the communication with the environment
> // and releases any associated resources.

Done.