Issue 6221060: Fix double pinyin parse error when fuzzy pinyin is enabled.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6221060: Fix double pinyin parse error when fuzzy pinyin is enabled. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by Peng

Modified:
11 years, 11 months ago

Reviewers:
hsumita1, Peng Wu, hsumita

Base URL:
git@github.com:ibus/ibus-pinyin.git@master

Visibility:
Public.

More Reviews

Description

Fix double pinyin parse error when fuzzy pinyin is enabled. BUG=http://code.google.com/p/ibus/issues/detail?id=1441 TEST=Manually

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -31 lines)			Patch
	M	src/PYDoublePinyinEditor.cc	View	1	1 chunk	+47 lines, -31 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

hsumita1

LGTM with nits BTW, Can I merge this patch into pyzy? https://codereview.appspot.com/6221060/diff/1/src/PYDoublePinyinEditor.cc File src/PYDoublePinyinEditor.cc (right): ...

11 years, 11 months ago (2012-05-23 03:19:23 UTC) #3

Peng

11 years, 11 months ago (2012-05-23 12:03:27 UTC) #5

http://codereview.appspot.com/6221060/diff/1/src/PYDoublePinyinEditor.cc
File src/PYDoublePinyinEditor.cc (right):

http://codereview.appspot.com/6221060/diff/1/src/PYDoublePinyinEditor.cc#newc...
src/PYDoublePinyinEditor.cc:380: break;;
On 2012/05/23 03:19:23, hsumita1 wrote:
> Please remove semicolon.

Done.

Expand All Messages | Collapse All Messages