Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1549)

Issue 62054: Enable pause/resume of NetDevice

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by Adrian
Modified:
8 years, 10 months ago
Reviewers:
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

In response to a mail from Duy Nguyen on ns-developers list, I added the pause/resume function to ns3::NetDevice to allow optional pausing of an interface. By default, these functions are not supported and always fail (by returning false) so that no code will break after this patch. I also implemented the pause/resume mechanism in PointToPointNetDevice and CsmaNetDevice. Other NetDevice implementations does not sounds sensable to me, for example a bridge should not be pause-able because it does not have buffer.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -8 lines) Patch
M src/devices/csma/csma-net-device.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/devices/csma/csma-net-device.cc View 5 chunks +40 lines, -6 lines 0 comments Download
M src/devices/point-to-point/point-to-point-net-device.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/devices/point-to-point/point-to-point-net-device.cc View 4 chunks +46 lines, -2 lines 0 comments Download
M src/node/net-device.h View 1 chunk +23 lines, -0 lines 0 comments Download
M src/node/net-device.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b