Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(955)

Issue 62030043: code review 62030043: ogle/probe: add a sanity check for heapStart and heapUsed. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by nigeltao
Modified:
7 years, 9 months ago
Reviewers:
r
CC:
r
Visibility:
Public.

Description

ogle/probe: add a sanity check for heapStart and heapUsed.

Patch Set 1 #

Patch Set 2 : diff -r 2a09d0b8adf8 https://code.google.com/p/ogle #

Patch Set 3 : diff -r 2a09d0b8adf8 https://code.google.com/p/ogle #

Patch Set 4 : diff -r 2a09d0b8adf8 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M probe/addr_test.go View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 9 months ago (2014-02-12 01:16:00 UTC) #1
r
LGTM
7 years, 9 months ago (2014-02-12 03:56:26 UTC) #2
nigeltao
7 years, 9 months ago (2014-02-12 06:17:08 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=915c0f97f00c ***

ogle/probe: add a sanity check for heapStart and heapUsed.

LGTM=r
R=r
https://codereview.appspot.com/62030043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b