Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2161)

Issue 61660043: Issue 362: add Resume() method to ResumableUpload (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by peleyal
Modified:
5 years, 10 months ago
Reviewers:
class
CC:
google-api-dotnet-client_googlegroups.com
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

Issue 362: add Resume() method to ResumableUpload

Patch Set 1 #

Patch Set 2 : minor #

Total comments: 2

Patch Set 3 : First request when resuming should be to query the server where the upload was interrupted at #

Patch Set 4 : minor #

Patch Set 5 : add try-catch on resuming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -83 lines) Patch
M Src/GoogleApis.Core/Apis/Requests/RequestBuilder.cs View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs View 1 2 3 14 chunks +87 lines, -48 lines 0 comments Download
M Src/GoogleApis/Apis/Requests/IClientServiceRequest.cs View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs View 1 2 3 4 8 chunks +114 lines, -29 lines 0 comments Download

Messages

Total messages: 3
peleyal
https://code.google.com/p/google-api-dotnet-client/issues/detail?id=362
5 years, 10 months ago (2014-02-10 17:15:13 UTC) #1
class
The changes are very minor, just one comment and LGTM. https://codereview.appspot.com/61660043/diff/20001/Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs File Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs (right): https://codereview.appspot.com/61660043/diff/20001/Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs#newcode393 ...
5 years, 10 months ago (2014-02-11 16:31:45 UTC) #2
peleyal
5 years, 10 months ago (2014-02-12 20:06:38 UTC) #3
Message was sent while issue was closed.
https://codereview.appspot.com/61660043/diff/20001/Src/GoogleApis/Apis/[Media...
File Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs (right):

https://codereview.appspot.com/61660043/diff/20001/Src/GoogleApis/Apis/[Media...
Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs:393: ///
<summary>Asynchronously resumes the upload form the last point it was
interrupted.</summary>
On 2014/02/11 16:31:46, class wrote:
> Might want to add a remark on what the difference between this and the other
> ResumeAsync is.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b