Issue 61650043: HTML(wiki) creation could not load editor (Closed)
|
Created:
10 years, 2 months ago by sksaurabhkathpalia Modified:
9 years, 10 months ago Reviewers:
thomas.j.waldmann, RogerHaase Visibility:
Public. |
DescriptionHTML(wiki) creation could not load editor
Patch Set 1 #Patch Set 2 : HTML(wiki) creation could not load editor #
Total comments: 5
Patch Set 3 : HTML(wiki) creation could not load editor #
Total comments: 3
Patch Set 4 : HTML(wiki) creation could not load editor #
Total comments: 8
Patch Set 5 : HTML(wiki) creation could not load editor #
Total comments: 6
Patch Set 6 : HTML(wiki) creation could not load editor #
Total comments: 2
Patch Set 7 : HTML(wiki) creation could not load editor #Patch Set 8 : Fixed the modify of Home #MessagesTotal messages: 14
quick things, still looking https://codereview.appspot.com/61650043/diff/20001/MoinMoin/themes/basic/temp... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/20001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:4: did you mean to add extra line here? https://codereview.appspot.com/61650043/diff/20001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:18: ditto https://codereview.appspot.com/61650043/diff/20001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:38: <div class="tab-pane active" id="editor"> if your editor does not have option to change tabs to spaces, you need a different editor...
Sign in to reply to this message.
https://codereview.appspot.com/61650043/diff/40001/MoinMoin/themes/basic/temp... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/40001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:37: why if here? is it possible to not have an editor and show a page with a comment field and save button? https://codereview.appspot.com/61650043/diff/40001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:37: why if here? Will there be a case where data_editor is not defined and we show an edit page without an edit area?
Sign in to reply to this message.
https://codereview.appspot.com/61650043/diff/20001/MoinMoin/themes/basic/temp... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/20001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:4: On 2014/02/10 17:09:18, RogerHaase wrote: > did you mean to add extra line here? Actually I made it my mistake https://codereview.appspot.com/61650043/diff/20001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:38: <div class="tab-pane active" id="editor"> On 2014/02/10 17:09:18, RogerHaase wrote: > if your editor does not have option to change tabs to spaces, you need a > different editor... Actually in this review I did not take care of the spaces and tabs.I just wanted to give a rough idea of my changes. Sorry for that My next one would be properly aligned :) https://codereview.appspot.com/61650043/diff/40001/MoinMoin/themes/basic/temp... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/40001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:37: On 2014/02/10 19:34:01, RogerHaase wrote: > why if here? is it possible to not have an editor and show a page with a comment > field and save button? Yeah there is no need of having an if statement. It was actually used for debugging purpose by me I am deleting it. https://codereview.appspot.com/61650043/diff/60001/MoinMoin/themes/basic/temp... File MoinMoin/themes/basic/templates/modify.html (left): https://codereview.appspot.com/61650043/diff/60001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:7: {% set basic_data_editor = content_template.basic_data_editor %} I imported the data_editor instead of basic_data_editor because that basic_data_editor was not defined So I took the editor of other themes. And it works fine with other themes. https://codereview.appspot.com/61650043/diff/60001/MoinMoin/themes/basic/temp... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/60001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:14: {% endif %} Without this the basic editor is loaded without any extra widgets which are required in the editor for html. I did so as there are widgets in other theme so I used that block head. https://codereview.appspot.com/61650043/diff/60001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:37: {{ content_template.data_editor(form['content_form'], item_name) }} Here I am displaying the editor .
Sign in to reply to this message.
Sign in to reply to this message.
https://codereview.appspot.com/61650043/diff/60001/MoinMoin/themes/basic/temp... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/60001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:5: {% import form['content_form'].template as content_template %} why did you remove theme(itemviews)? https://codereview.appspot.com/61650043/diff/60001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:7: {% set data_editor = content_template.data_editor %} where do you use data_editor? why do you use content_template.data_editor in line 37?
Sign in to reply to this message.
https://codereview.appspot.com/61650043/diff/60001/MoinMoin/themes/basic/temp... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/60001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:7: {% set data_editor = content_template.data_editor %} On 2014/02/13 21:42:34, Thomas.J.Waldmann wrote: > where do you use data_editor? > why do you use content_template.data_editor in line 37? Actually in the 37 line I was supposed to used data_editor only. I will correct this in my new patch
Sign in to reply to this message.
https://codereview.appspot.com/61650043/diff/60001/MoinMoin/themes/basic/temp... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/60001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:5: {% import form['content_form'].template as content_template %} On 2014/02/13 21:42:34, Thomas.J.Waldmann wrote: > why did you remove theme(itemviews)? I think it was done by me accidently Sorry for that
Sign in to reply to this message.
https://codereview.appspot.com/61650043/diff/80001/MoinMoin/themes/basic/temp... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/80001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:7: {% set extra_head = content_template.extra_head %} Extra Head is displaying the widgets such as Bold,Underline etc
Sign in to reply to this message.
Sign in to reply to this message.
https://codereview.appspot.com/61650043/diff/60001/MoinMoin/themes/basic/temp... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/60001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:5: {% import form['content_form'].template as content_template %} maybe some general questions: a) do you practically try your changes and compare the effects of them to the state before as well as to the state seen in the other themes? b) do you read the diffs / the stuff you post to codereview before commit / before asking for code review? https://codereview.appspot.com/61650043/diff/80001/MoinMoin/themes/basic/temp... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/80001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:14: {% endblock %} please move this below block head https://codereview.appspot.com/61650043/diff/80001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:42: {{ data_editor(form['content_form'], item_name) }} compared to the base version, you removed class='form-control' - what was it for and why did you remove it?
Sign in to reply to this message.
https://codereview.appspot.com/61650043/diff/80001/MoinMoin/themes/basic/temp... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/80001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:42: {{ data_editor(form['content_form'], item_name) }} On 2014/02/14 13:45:38, Thomas.J.Waldmann wrote: > compared to the base version, you removed class='form-control' - what was it for > and why did you remove it? The class was not defined for the data_editor.
Sign in to reply to this message.
https://codereview.appspot.com/61650043/diff/80001/MoinMoin/themes/basic/temp... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/80001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:42: {{ data_editor(form['content_form'], item_name) }} > The class was not defined for the data_editor. You mean not defined in css? I see lots of .form-control definitions there. Asked in a different way: what issue did you fix by removing it? https://codereview.appspot.com/61650043/diff/100001/MoinMoin/themes/basic/tem... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/100001/MoinMoin/themes/basic/tem... MoinMoin/themes/basic/templates/modify.html:17: {% endblock %} please keep an empty line between blocks, as you see it in existing template.
Sign in to reply to this message.
https://codereview.appspot.com/61650043/diff/100001/MoinMoin/themes/basic/tem... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/100001/MoinMoin/themes/basic/tem... MoinMoin/themes/basic/templates/modify.html:17: {% endblock %} On 2014/02/14 15:17:36, Thomas.J.Waldmann wrote: > please keep an empty line between blocks, as you see it in existing template. Ok doing that :)
Sign in to reply to this message.
https://codereview.appspot.com/61650043/diff/80001/MoinMoin/themes/basic/temp... File MoinMoin/themes/basic/templates/modify.html (right): https://codereview.appspot.com/61650043/diff/80001/MoinMoin/themes/basic/temp... MoinMoin/themes/basic/templates/modify.html:42: {{ data_editor(form['content_form'], item_name) }} On 2014/02/14 15:17:35, Thomas.J.Waldmann wrote: > > The class was not defined for the data_editor. > > You mean not defined in css? I see lots of .form-control definitions there. > > Asked in a different way: what issue did you fix by removing it? When we add class then it shows that there is no class attribute defined for this. Thats why I removed the class='form-control'
Sign in to reply to this message.
|
