Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(899)

Issue 6159044: s3: add Bucket.URL method

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by rog
Modified:
11 years, 11 months ago
Reviewers:
mp+104401
Visibility:
Public.

Description

s3: add Bucket.URL method No pre-signed URLs yet though. https://code.launchpad.net/~rogpeppe/goamz/master/+merge/104401 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : s3: add Bucket.URL method #

Total comments: 1

Patch Set 3 : s3: add Bucket.URL method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M s3/s3.go View 1 chunk +12 lines, -0 lines 0 comments Download
M s3/s3_test.go View 2 chunks +18 lines, -0 lines 0 comments Download
M s3/s3i_test.go View 4 chunks +10 lines, -2 lines 0 comments Download
M s3/suite_test.go View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
11 years, 11 months ago (2012-05-02 15:24:48 UTC) #1
niemeyer
LGTM https://codereview.appspot.com/6159044/diff/2001/s3/s3i_test.go File s3/s3i_test.go (right): https://codereview.appspot.com/6159044/diff/2001/s3/s3i_test.go#newcode114 s3/s3i_test.go:114: for _ = range allRegions { Nice. :)
11 years, 11 months ago (2012-05-03 16:38:25 UTC) #2
rog
11 years, 11 months ago (2012-05-03 16:41:35 UTC) #3
*** Submitted:

s3: add Bucket.URL method

No pre-signed URLs yet though.

R=
CC=
https://codereview.appspot.com/6159044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b