Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(829)

Issue 6157045: code review 6157045: os: move Plan 9 directory marshaling code to syscall (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by ality
Modified:
11 years, 4 months ago
Reviewers:
CC:
akumar, rsc, rminnich, aam, dfc, golang-dev, lucio
Visibility:
Public.

Description

os: move Plan 9 directory marshaling code to syscall The API additions to syscall are in dir_plan9.go.

Patch Set 1 #

Patch Set 2 : diff -r 77cbd63c1991 https://code.google.com/p/go/ #

Patch Set 3 : diff -r cfa9208b98fc https://code.google.com/p/go/ #

Patch Set 4 : diff -r e3d1b93bfa09 https://code.google.com/p/go/ #

Total comments: 9

Patch Set 5 : diff -r e3d1b93bfa09 https://code.google.com/p/go/ #

Patch Set 6 : diff -r f2755950769b https://code.google.com/p/go/ #

Total comments: 2

Patch Set 7 : diff -r 026b89723112 https://code.google.com/p/go/ #

Patch Set 8 : diff -r d686006f8945 https://code.google.com/p/go/ #

Patch Set 9 : diff -r 8f9a26de2b20 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -290 lines) Patch
M src/pkg/os/dir_plan9.go View 1 2 3 4 5 6 7 3 chunks +28 lines, -231 lines 0 comments Download
M src/pkg/os/file_plan9.go View 1 2 3 4 5 6 9 chunks +64 lines, -28 lines 0 comments Download
M src/pkg/os/stat_plan9.go View 1 2 3 4 chunks +20 lines, -16 lines 0 comments Download
A src/pkg/syscall/dir_plan9.go View 1 2 3 4 5 1 chunk +205 lines, -0 lines 0 comments Download
M src/pkg/syscall/exec_plan9.go View 1 2 2 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 13
ality
Hello seed@mail.nanosouffle.net, rsc@golang.org (cc: golang-dev@googlegroups.com, lucio.dere@gmail.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 5 months ago (2012-10-12 20:52:24 UTC) #1
rsc
fine with me but please wait for another plan 9 user to sign off
11 years, 5 months ago (2012-10-16 17:22:46 UTC) #2
ality
+ rminnich, aam
11 years, 4 months ago (2012-11-08 03:33:21 UTC) #3
aam
LGTM
11 years, 4 months ago (2012-11-08 04:28:27 UTC) #4
dfc
Some minor comments. https://codereview.appspot.com/6157045/diff/9001/src/pkg/os/dir_plan9.go File src/pkg/os/dir_plan9.go (right): https://codereview.appspot.com/6157045/diff/9001/src/pkg/os/dir_plan9.go#newcode12 src/pkg/os/dir_plan9.go:12: func (file *File) readdir(n int) (fi ...
11 years, 4 months ago (2012-11-08 04:30:21 UTC) #5
ality
https://codereview.appspot.com/6157045/diff/9001/src/pkg/os/dir_plan9.go File src/pkg/os/dir_plan9.go (right): https://codereview.appspot.com/6157045/diff/9001/src/pkg/os/dir_plan9.go#newcode12 src/pkg/os/dir_plan9.go:12: func (file *File) readdir(n int) (fi []FileInfo, err error) ...
11 years, 4 months ago (2012-11-08 04:55:28 UTC) #6
dfc
> Yeah. I'm not happy about this comment. Any ideas for a better wording? > ...
11 years, 4 months ago (2012-11-08 04:56:28 UTC) #7
ality
PTAL https://codereview.appspot.com/6157045/diff/9001/src/pkg/syscall/dir_plan9.go File src/pkg/syscall/dir_plan9.go (right): https://codereview.appspot.com/6157045/diff/9001/src/pkg/syscall/dir_plan9.go#newcode55 src/pkg/syscall/dir_plan9.go:55: // Null assigns special "don't-touch" values to members ...
11 years, 4 months ago (2012-11-22 18:20:55 UTC) #8
rsc
https://codereview.appspot.com/6157045/diff/21001/src/pkg/os/file_plan9.go File src/pkg/os/file_plan9.go (right): https://codereview.appspot.com/6157045/diff/21001/src/pkg/os/file_plan9.go#newcode181 src/pkg/os/file_plan9.go:181: if err := syscall.Fwstat(f.fd, buf[:]); err != nil { ...
11 years, 4 months ago (2012-11-26 16:50:42 UTC) #9
ality
PTAL https://codereview.appspot.com/6157045/diff/21001/src/pkg/os/file_plan9.go File src/pkg/os/file_plan9.go (right): https://codereview.appspot.com/6157045/diff/21001/src/pkg/os/file_plan9.go#newcode181 src/pkg/os/file_plan9.go:181: if err := syscall.Fwstat(f.fd, buf[:]); err != nil ...
11 years, 4 months ago (2012-11-26 17:59:19 UTC) #10
ality
PTAL Fixed a bug I introduced in a previous patchset.
11 years, 4 months ago (2012-11-26 22:46:45 UTC) #11
rsc
LGTM
11 years, 4 months ago (2012-11-26 22:57:34 UTC) #12
ality
11 years, 4 months ago (2012-11-26 23:26:53 UTC) #13
*** Submitted as http://code.google.com/p/go/source/detail?r=fc24aee70702 ***

os: move Plan 9 directory marshaling code to syscall

The API additions to syscall are in dir_plan9.go.

R=seed, rsc, rminnich, mirtchovski, dave
CC=golang-dev, lucio.dere
http://codereview.appspot.com/6157045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b