Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(677)

Issue 61480044: code review 61480044: go.tools/cmd/vet: add stable checks to doc.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by adg
Modified:
5 years, 4 months ago
Reviewers:
r
CC:
r, golang-codereviews
Visibility:
Public.

Description

go.tools/cmd/vet: add stable checks to doc.go These are the simplest possible descriptions of each command. They may be fleshed out later. Fixes issue 7298.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r c94b6fa807e8 https://code.google.com/p/go.tools #

Total comments: 2

Patch Set 3 : diff -r 3bbdb0ce2660 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -9 lines) Patch
M cmd/vet/doc.go View 1 2 5 chunks +79 lines, -9 lines 0 comments Download

Messages

Total messages: 10
adg
Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
5 years, 4 months ago (2014-02-11 06:45:38 UTC) #1
r
I wonder if this is such a good idea. Should this be in the vet ...
5 years, 4 months ago (2014-02-11 06:52:00 UTC) #2
adg
This is the vet tool's doc.go (nothing to do with cmd/go) as viewable here: http://godoc.org/code.google.com/p/go.tools/cmd/vet ...
5 years, 4 months ago (2014-02-11 06:55:46 UTC) #3
r
Yes, I know what it is. I'm asking where the information belongs. It feels fragile ...
5 years, 4 months ago (2014-02-11 15:44:40 UTC) #4
adg
"godoc code.google.com/p/go.tools/cmd/vet" also provides these same docs. Since we need to invoke vet with "go ...
5 years, 4 months ago (2014-02-12 22:59:04 UTC) #5
r
Sigh. I was arguing that you should do exactly what you did. I read it ...
5 years, 4 months ago (2014-02-12 23:01:49 UTC) #6
r
https://codereview.appspot.com/61480044/diff/1/cmd/vet/doc.go File cmd/vet/doc.go (right): https://codereview.appspot.com/61480044/diff/1/cmd/vet/doc.go#newcode28 cmd/vet/doc.go:28: Printf family i like the numbers because the break ...
5 years, 4 months ago (2014-02-12 23:03:19 UTC) #7
adg
Hello r@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
5 years, 4 months ago (2014-02-12 23:43:39 UTC) #8
r
LGTM but do the renumbering first. https://codereview.appspot.com/61480044/diff/20001/cmd/vet/doc.go File cmd/vet/doc.go (right): https://codereview.appspot.com/61480044/diff/20001/cmd/vet/doc.go#newcode28 cmd/vet/doc.go:28: Printf family isn't ...
5 years, 4 months ago (2014-02-12 23:46:08 UTC) #9
adg
5 years, 4 months ago (2014-02-13 00:05:11 UTC) #10
*** Submitted as
https://code.google.com/p/go/source/detail?r=698202246815&repo=tools ***

go.tools/cmd/vet: add stable checks to doc.go

These are the simplest possible descriptions of each command.
They may be fleshed out later.

Fixes issue 7298.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/61480044

https://codereview.appspot.com/61480044/diff/20001/cmd/vet/doc.go
File cmd/vet/doc.go (right):

https://codereview.appspot.com/61480044/diff/20001/cmd/vet/doc.go#newcode28
cmd/vet/doc.go:28: Printf family
On 2014/02/12 23:46:09, r wrote:
> isn't this 1.?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b