provider/manual: set storage in SetConfig

provider/manual: set storage in SetConfig

We currently rely on EnableBootstrapStorage to
specify the storage mechanism to use for bootstrap
and sync-tools. This is insufficient in practice,
causing panics such as those in lp:1262764.

Instead, we inject a boolean attribute into the
environment config that is stored in state; this
attribute is false in the .jenv file, and true
in state. We use its value to decide whether to
use sshstorage (external) or httpstorage (internal).

A followup will eliminate BootstrapStorager.

Fixes lp:1262764

https://code.launchpad.net/~axwalk/juju-core/lp1262764-manual-storage-setconfig/+merge/205530

(do not edit description out of merge proposal)

[axw, 2014-02-10 07:52:14]

Please take a look.

[dimitern, 2014-02-10 09:28:06]

I'm not so sure about the flag name vs. what's its meaning. See below.

Other than that, it looks solid.

https://codereview.appspot.com/61480043/diff/1/provider/manual/config.go
File provider/manual/config.go (right):

https://codereview.appspot.com/61480043/diff/1/provider/manual/config.go#newc...
provider/manual/config.go:22: "bootstrapped":      schema.Bool(),
This looks a bit dubious - if the purpose of this flag (as seen later in tests)
is to make a decision which storage to use, then why not call it
"use-httpstorage" or something? That way, for older environments it will be
"false" by default, and we get the same logic, don't we?

[axw, 2014-02-10 09:34:36]

On 2014/02/10 09:28:06, dimitern wrote:
> I'm not so sure about the flag name vs. what's its meaning. See below.
> 
> Other than that, it looks solid.
> 
> https://codereview.appspot.com/61480043/diff/1/provider/manual/config.go
> File provider/manual/config.go (right):
> 
>
https://codereview.appspot.com/61480043/diff/1/provider/manual/config.go#newc...
> provider/manual/config.go:22: "bootstrapped":      schema.Bool(),
> This looks a bit dubious - if the purpose of this flag (as seen later in
tests)
> is to make a decision which storage to use, then why not call it
> "use-httpstorage" or something? That way, for older environments it will be
> "false" by default, and we get the same logic, don't we?

Good idea, thanks. I'll update that tomorrow.

[axw, 2014-02-10 11:59:04]

Please take a look.

[dimitern, 2014-02-10 12:15:47]

Thanks! LGTM.