Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1305)

Issue 6124051: jujuc client executable

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by fwereade
Modified:
11 years, 11 months ago
Reviewers:
mp+103693
Visibility:
Public.

Description

jujuc client executable https://code.launchpad.net/~fwereade/juju/go-jujuc-client/+merge/103693 Requires: https://code.launchpad.net/~fwereade/juju/go-jujuc-server/+merge/103678 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 15

Patch Set 2 : jujuc client executable #

Patch Set 3 : jujuc client executable #

Total comments: 10

Patch Set 4 : jujuc client executable #

Patch Set 5 : jujuc client executable #

Total comments: 1

Patch Set 6 : jujuc client executable #

Patch Set 7 : jujuc client executable #

Patch Set 8 : jujuc client executable #

Total comments: 10

Patch Set 9 : jujuc client executable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -0 lines) Patch
A [revision details] View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
A cmd/jujuc/main.go View 1 2 3 4 5 6 7 8 1 chunk +89 lines, -0 lines 0 comments Download
A cmd/jujuc/main_test.go View 1 2 3 4 5 6 7 8 1 chunk +160 lines, -0 lines 0 comments Download

Messages

Total messages: 19
fwereade
Please take a look.
11 years, 11 months ago (2012-04-26 13:41:42 UTC) #1
rog
looks good. https://codereview.appspot.com/6124051/diff/1/cmd/jujuc/main.go File cmd/jujuc/main.go (right): https://codereview.appspot.com/6124051/diff/1/cmd/jujuc/main.go#newcode13 cmd/jujuc/main.go:13: fmt.Fprintf(os.Stderr, "FATAL: %v\n", err) s/FATAL/%s: error: / ...
11 years, 11 months ago (2012-04-27 10:58:23 UTC) #2
fwereade
Please take a look. https://codereview.appspot.com/6124051/diff/1/cmd/jujuc/main.go File cmd/jujuc/main.go (right): https://codereview.appspot.com/6124051/diff/1/cmd/jujuc/main.go#newcode14 cmd/jujuc/main.go:14: fmt.Fprintf(os.Stderr, server.JUJUC_DOC) On 2012/04/27 10:58:23, ...
11 years, 11 months ago (2012-04-27 13:44:23 UTC) #3
fwereade
Please take a look.
11 years, 11 months ago (2012-04-27 13:47:15 UTC) #4
rog
LGTM modulo below. https://codereview.appspot.com/6124051/diff/1/cmd/jujuc/main.go File cmd/jujuc/main.go (right): https://codereview.appspot.com/6124051/diff/1/cmd/jujuc/main.go#newcode43 cmd/jujuc/main.go:43: // arguments. Individual commands should be ...
11 years, 11 months ago (2012-04-27 14:16:30 UTC) #5
fwereade
Please take a look. https://codereview.appspot.com/6124051/diff/8001/cmd/jujuc/main.go File cmd/jujuc/main.go (right): https://codereview.appspot.com/6124051/diff/8001/cmd/jujuc/main.go#newcode16 cmd/jujuc/main.go:16: `[1:] On 2012/04/27 14:16:31, rog ...
11 years, 11 months ago (2012-04-27 16:02:41 UTC) #6
fwereade
Please take a look.
11 years, 11 months ago (2012-04-30 01:01:30 UTC) #7
rog
On 2012/04/30 01:01:30, fwereade wrote: > Please take a look. LGTM
11 years, 11 months ago (2012-04-30 07:40:15 UTC) #8
niemeyer
Thanks for keeping this so simple. I have a minor request if that's ok: https://codereview.appspot.com/6124051/diff/12001/cmd/jujuc/main.go ...
11 years, 11 months ago (2012-05-02 23:21:51 UTC) #9
fwereade
On 2012/05/02 23:21:51, niemeyer wrote: > Thanks for keeping this so simple. I have a ...
11 years, 11 months ago (2012-05-03 08:38:43 UTC) #10
fwereade
On 2012/05/03 08:38:43, fwereade wrote: > OK, I'd hoped this was compact enough that it'd ...
11 years, 11 months ago (2012-05-03 08:46:38 UTC) #11
fwereade
Please take a look.
11 years, 11 months ago (2012-05-03 08:47:41 UTC) #12
fwereade
On 2012/05/03 08:47:41, fwereade wrote: > Please take a look. (oh, blast, ignore this for ...
11 years, 11 months ago (2012-05-03 09:55:26 UTC) #13
fwereade
Please take a look.
11 years, 11 months ago (2012-05-03 10:20:23 UTC) #14
niemeyer
On 2012/05/03 08:46:38, fwereade wrote: > Hmm; I don't want logic in main(), because I ...
11 years, 11 months ago (2012-05-03 15:58:43 UTC) #15
fwereade
Please take a look.
11 years, 11 months ago (2012-05-03 16:39:53 UTC) #16
niemeyer
I thought we had agreed that the idea was to return the error value from ...
11 years, 11 months ago (2012-05-03 17:30:52 UTC) #17
fwereade
On 2012/05/03 17:30:52, niemeyer wrote: > I thought we had agreed that the idea was ...
11 years, 11 months ago (2012-05-03 19:54:38 UTC) #18
fwereade
11 years, 11 months ago (2012-05-03 21:02:10 UTC) #19
*** Submitted:

jujuc client executable

R=rog, niemeyer
CC=
https://codereview.appspot.com/6124051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b