Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1673)

Issue 6102045: Change \bendAfter and \rightHandFinger into event functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by dak
Modified:
7 years, 1 month ago
Reviewers:
Graham Percival
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Change \bendAfter and \rightHandFinger into event functions

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Graham's one-line complaint. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M Documentation/notation/expressive.itely View 1 chunk +6 lines, -10 lines 0 comments Download
M Documentation/notation/fretted-strings.itely View 1 1 chunk +9 lines, -9 lines 0 comments Download
M ly/music-functions-init.ly View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Graham Percival
LGTM http://codereview.appspot.com/6102045/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/6102045/diff/1/Documentation/notation/fretted-strings.itely#newcode1589 Documentation/notation/fretted-strings.itely:1589: <e\rightHandFinger 2> oh god. At one point, we ...
7 years, 2 months ago (2012-04-23 03:45:38 UTC) #1
dak
7 years, 2 months ago (2012-04-23 09:05:32 UTC) #2
http://codereview.appspot.com/6102045/diff/1/Documentation/notation/fretted-s...
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/6102045/diff/1/Documentation/notation/fretted-s...
Documentation/notation/fretted-strings.itely:1589: <e\rightHandFinger 2>
On 2012/04/23 03:45:38, Graham Percival wrote:
> oh god.  At one point, we tried to eliminate all #-less numbers to avoid
> confusion like this.
> 
> I know that you're proud of parser work which lets us write a bare 2 here, but
I
> fear this would lead to user confusion and not be a net positive.  Could we
> leave the #2 > there?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b