Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(202)

Issue 6099046: Document "fingerings" being frets rather than fingers for fretted instruments. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by dak
Modified:
7 years, 2 months ago
Reviewers:
carl.d.sorensen, Trevor Daniels
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Document "fingerings" being frets rather than fingers for fretted instruments.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Documentation/notation/fretted-strings.itely View 1 chunk +4 lines, -1 line 3 comments Download

Messages

Total messages: 3
Trevor Daniels
One nitpick; otherwise LGTM http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-strings.itely#newcode68 Documentation/notation/fretted-strings.itely:68: when assigning strings, this distinction ...
7 years, 2 months ago (2012-04-22 20:03:55 UTC) #1
Carl
I believe that this is wrong -- fingerings are fingers for fretted instruments, not frets. ...
7 years, 2 months ago (2012-04-22 21:03:12 UTC) #2
dak
7 years, 2 months ago (2012-04-22 22:04:41 UTC) #3
http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-s...
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-s...
Documentation/notation/fretted-strings.itely:68: when assigning strings, this
distinction is not academical.
On 2012/04/22 21:03:12, Carl wrote:
> I don't think this is true.
> 
> Fingerings specify string and finger; the fret is automatically calculated.
> 
> Tablature notations heed string assignments, which determine frets.  Then
> non-assigned strings try to find frets within a specified reach.
> 
> I think this paragraph is wrong.  If it is right, please create a snippet that
> shows the difference.

The documentation itself contains examples with "finger" 6 6 7 or so: I think it
was me who added them some time ago.  Checking the code, it might indeed be that
the only question asked of the fingering might be "0 or not".  I will
cross-check with actual tablatures tomorrow.

If you are right, the existing examples in the docs need some changes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b