Issue 6074044: state, environs/ec2: connect using SSH

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by rog

Modified:
12 years ago

Reviewers:
mp+102731

Visibility:
Public.

Description

state, environs/ec2: connect using SSH https://code.launchpad.net/~rogpeppe/juju/go-connect-with-ssh/+merge/102731 Requires: https://code.launchpad.net/~rogpeppe/juju/go-ssh-connect/+merge/100281 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state, environs/ec2: connect using SSH #

Patch Set 3 : state, environs/ec2: connect using SSH #

Total comments: 6

Patch Set 4 : state, environs/ec2: connect using SSH #

Patch Set 5 : state, environs/ec2: connect using SSH #

Patch Set 6 : state, environs/ec2: connect using SSH #

Total comments: 2

Patch Set 7 : state, environs/ec2: connect using SSH #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -27 lines)			Patch
A	[revision details]	View	1 2 3 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/ec2/cloudinit.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	environs/ec2/ec2.go	View	1	2 chunks	+4 lines, -9 lines	0 comments	Download
M	environs/ec2/live_test.go	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	state/open.go	View	1 2 3 4 5	3 chunks	+35 lines, -11 lines	0 comments	Download
M	state/ssh.go	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	state/ssh_test.go	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	state/state.go	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

niemeyer

It's most probably a looks-good, but please re-push to clean the CL up. There are ...

12 years ago (2012-04-24 00:31:14 UTC) #3

rog

Please take a look. https://codereview.appspot.com/6074044/diff/6001/state/open.go File state/open.go (right): https://codereview.appspot.com/6074044/diff/6001/state/open.go#newcode16 state/open.go:16: // Addrs gives the addresses ...

12 years ago (2012-04-24 08:38:49 UTC) #4

niemeyer

LGTM https://codereview.appspot.com/6074044/diff/14002/state/open.go File state/open.go (right): https://codereview.appspot.com/6074044/diff/14002/state/open.go#newcode65 state/open.go:65: fwd, zk, err := sshDial(info.Addrs[0], "") A bit ...

12 years ago (2012-04-25 05:40:07 UTC) #5

rog

12 years ago (2012-04-25 10:14:16 UTC) #6

*** Submitted:

state, environs/ec2: connect using SSH

R=niemeyer
CC=
https://codereview.appspot.com/6074044

https://codereview.appspot.com/6074044/diff/14002/state/open.go
File state/open.go (right):

https://codereview.appspot.com/6074044/diff/14002/state/open.go#newcode65
state/open.go:65: fwd, zk, err := sshDial(info.Addrs[0], "")
On 2012/04/25 05:40:07, niemeyer wrote:
> A bit sad that we don't have a good way to test this.

it is being tested. the ec2 client connects with UseSSH=true.
but perhaps you're referring to a different aspect?

Expand All Messages | Collapse All Messages