Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(298)

Issue 6068045: Add announcements to the upper right corner of the website (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by MikeSol
Modified:
6 years, 10 months ago
Reviewers:
mike, dak, mike7, Graham Percival, hanwenn, janneke
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add announcements to the upper right corner of the website

Patch Set 1 #

Patch Set 2 : Makes rotating announcement corner #

Patch Set 3 : Uses separate tweets.xml file for tweets #

Total comments: 1

Patch Set 4 : Second attempt to upload XML file. #

Patch Set 5 : Updates URL in anchor to main Kickstarter tour site. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1 line) Patch
M Documentation/css/lilypond-website.css View 1 2 chunks +18 lines, -1 line 0 comments Download
M Documentation/web.texi View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A Documentation/web/server/tweets.xml View 1 2 3 4 Binary file 0 comments Download
M make/website.make View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 23
MikeSol
Hey all, My ensemble is launching a Kickstarter project in a day or two to ...
7 years, 2 months ago (2012-04-19 13:51:54 UTC) #1
dak
mtsolo@gmail.com writes: > Reviewers: , > > Message: > Hey all, > > My ensemble ...
7 years, 2 months ago (2012-04-19 14:40:31 UTC) #2
mike_apollinemike.com
On Apr 19, 2012, at 4:40 PM, David Kastrup wrote: > mtsolo@gmail.com writes: > >> ...
7 years, 2 months ago (2012-04-19 15:52:25 UTC) #3
Graham Percival
On Thu, Apr 19, 2012 at 04:40:08PM +0200, David Kastrup wrote: > mtsolo@gmail.com writes: > ...
7 years, 2 months ago (2012-04-19 17:10:46 UTC) #4
mike_apollinemike.com
On Apr 19, 2012, at 7:10 PM, Graham Percival wrote: > On Thu, Apr 19, ...
7 years, 2 months ago (2012-04-19 22:25:17 UTC) #5
dak
On 2012/04/19 22:25:17, mike_apollinemike.com wrote: > The real-estate value of the upper right corner of ...
7 years, 2 months ago (2012-04-20 08:57:05 UTC) #6
Graham Percival
First, editing embedded javascript is not a general solution. Second, I'm not at all certain ...
7 years, 2 months ago (2012-04-25 11:25:02 UTC) #7
mike7
On 2012/04/25 11:25:02, Graham Percival wrote: > First, editing embedded javascript is not a general ...
7 years, 2 months ago (2012-04-25 11:28:59 UTC) #8
Graham Percival
I like the content of the announcement. I still don't like the idea of manually ...
7 years, 2 months ago (2012-04-26 06:07:14 UTC) #9
mike7
Hey all, The new patchset puts the tweets in a separate xml file. I use ...
7 years, 1 month ago (2012-04-27 07:48:00 UTC) #10
mike7
I also just realized that git-cl does not know how to play nicely with the ...
7 years, 1 month ago (2012-04-27 07:49:30 UTC) #11
mike7
Hmm...it looks like the xml mime type is defined, so I'm short on ideas for ...
7 years, 1 month ago (2012-04-27 07:52:02 UTC) #12
Graham Percival
On 2012/04/27 07:49:30, mike7 wrote: > I also just realized that git-cl does not know ...
7 years, 1 month ago (2012-04-27 07:53:06 UTC) #13
Graham Percival
LGTM, one minor question but it's ok with me. http://codereview.appspot.com/6068045/diff/13001/Documentation/web.texi File Documentation/web.texi (right): http://codereview.appspot.com/6068045/diff/13001/Documentation/web.texi#newcode172 Documentation/web.texi:172: ...
7 years, 1 month ago (2012-04-27 07:55:54 UTC) #14
mike7
On 2012/04/27 07:53:06, Graham Percival wrote: > On 2012/04/27 07:49:30, mike7 wrote: > > I ...
7 years, 1 month ago (2012-04-27 07:58:50 UTC) #15
mike7
On 2012/04/27 07:55:54, Graham Percival wrote: > LGTM, one minor question but it's ok with ...
7 years, 1 month ago (2012-04-27 07:59:38 UTC) #16
Graham Percival
On 2012/04/27 07:58:50, mike7 wrote: > > Have you tried adding it to line 26 ...
7 years, 1 month ago (2012-04-27 07:59:58 UTC) #17
hanwenn
Totally off the wall idea here: Is it possilble to display the contents of the ...
7 years, 1 month ago (2012-04-27 12:19:55 UTC) #18
Graham Percival
On Fri, Apr 27, 2012 at 09:19:55AM -0300, Han-Wen Nienhuys wrote: > Is it possilble ...
7 years, 1 month ago (2012-04-27 12:39:49 UTC) #19
hanwenn
Who is GNU_LilyPond anyway? I thought it was, but I might be mistaken. On Fri, ...
7 years, 1 month ago (2012-04-27 13:15:33 UTC) #20
hanwenn
On Fri, Apr 27, 2012 at 10:15 AM, Han-Wen Nienhuys <hanwenn@gmail.com> wrote: > Who is ...
7 years, 1 month ago (2012-04-27 13:18:24 UTC) #21
Graham Percival
On Fri, Apr 27, 2012 at 10:18:23AM -0300, Han-Wen Nienhuys wrote: > On Fri, Apr ...
7 years, 1 month ago (2012-04-27 13:24:35 UTC) #22
janneke_gnu.org
7 years, 1 month ago (2012-05-01 20:30:55 UTC) #23
Graham Percival writes:

> On Fri, Apr 27, 2012 at 10:18:23AM -0300, Han-Wen Nienhuys wrote:
>> On Fri, Apr 27, 2012 at 10:15 AM, Han-Wen Nienhuys <hanwenn@gmail.com>
wrote:
>> > Who is GNU_LilyPond anyway?  I thought it was, but I might be mistaken.
>> 
>> I mean: I thought it was Jan.
>
> yeah, it's Jan.

yes, /currently/ it's me, but as you can see, it could do with some love

Jan

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar®  http://AvatarAcademy.nl  
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b