Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(854)

Issue 60650043: state/apiserver: tag() for disconnect

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by jameinel
Modified:
10 years, 1 month ago
Reviewers:
mp+205172, rog
Visibility:
Public.

Description

state/apiserver: tag() for disconnect We put tag() everywhere that we can, so that it is easy to see who is making a particular request. It is also useful to see this in the disconnect case. (eg, it makes it clear that user-admin is disconnecting, and not a particular agent.) https://code.launchpad.net/~jameinel/juju-core/disconnect-msg/+merge/205172 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/apiserver/apiserver.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
jameinel
Please take a look.
10 years, 1 month ago (2014-02-06 14:42:32 UTC) #1
rog
LGTM
10 years, 1 month ago (2014-02-06 14:49:56 UTC) #2
rog
10 years, 1 month ago (2014-02-06 14:49:58 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b