code review 6058043: compress/zlib: minor fixes

compress/zlib: minor fixes

[zhai, 2012-04-17 04:33:09]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
http://code.google.com/p/go/

[dfc, 2012-04-17 08:59:01]

Thank you for fixing this. As this is example code, would I be able to
convince you to extend your patch a little and convert this code into
an ExampleNewReader example?

Cheers

Dave

On Tue, Apr 17, 2012 at 2:33 PM,  <qyzhai@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> http://code.google.com/p/go/
>
>
> Description:
> compress/zlib: minor fixes
>
> Please review this at http://codereview.appspot.com/6058043/
>
> Affected files:
>  M src/pkg/compress/zlib/reader.go
>
>
> Index: src/pkg/compress/zlib/reader.go
> ===================================================================
> --- a/src/pkg/compress/zlib/reader.go
> +++ b/src/pkg/compress/zlib/reader.go
> @@ -11,7 +11,7 @@
>  to a buffer:
>
>        var b bytes.Buffer
> -       w, err := zlib.NewWriter(&b)
> +       w := zlib.NewWriter(&b)
>        w.Write([]byte("hello, world\n"))
>        w.Close()
>
>
>

[zhai, 2012-04-17 12:44:42]

Hello golang-dev@googlegroups.com, dave@cheney.net (cc:
golang-dev@googlegroups.com),

Please take another look.

[zhai, 2012-04-17 13:15:20]

Hello golang-dev@googlegroups.com, dave@cheney.net (cc:
golang-dev@googlegroups.com),

Please take another look.

[dfc, 2012-04-18 00:03:45]

LGTM. Thank you for adding some nice examples.

[zhai, 2012-04-21 00:08:19]

ping

On Wed, Apr 18, 2012 at 8:03 AM, <dave@cheney.net> wrote:

> LGTM. Thank you for adding some nice examples.
>
>
http://codereview.appspot.com/**6058043/<http://codereview.appspot.com/6058043/>
>

[dfc, 2012-04-21 00:13:14]

Assuming there is no more discussion, I'll submit this today.

On Sat, Apr 21, 2012 at 10:08 AM, zhai <qyzhai@gmail.com> wrote:
> ping
>
>
> On Wed, Apr 18, 2012 at 8:03 AM, <dave@cheney.net> wrote:
>>
>> LGTM. Thank you for adding some nice examples.
>>
>> http://codereview.appspot.com/6058043/
>
>

[dfc, 2012-04-21 04:34:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=23c94e7b3fd6 ***

compress/zlib: minor fixes

R=golang-dev, dave
CC=golang-dev
http://codereview.appspot.com/6058043

Committer: Dave Cheney <dave@cheney.net>