Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 6058043: code review 6058043: compress/zlib: minor fixes

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by zhai
Modified:
1 month, 1 week ago
Reviewers:
dfc, gl
CC:
golang-dev, dfc
Visibility:
Public.

Description

compress/zlib: minor fixes

Patch Set 1 #

Patch Set 2 : diff -r 99292bad0d6d http://code.google.com/p/go/ #

Patch Set 3 : diff -r 99292bad0d6d http://code.google.com/p/go/ #

Patch Set 4 : diff -r 99292bad0d6d http://code.google.com/p/go/ #

Patch Set 5 : diff -r 99292bad0d6d http://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
A src/pkg/compress/zlib/example_test.go View 1 2 3 4 1 chunk +37 lines, -0 lines 0 comments Download
M src/pkg/compress/zlib/reader.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
zhai
Hello golang-dev@googlegroups.com, I'd like you to review this change to http://code.google.com/p/go/
9 years, 6 months ago (2012-04-17 04:33:09 UTC) #1
dfc
Thank you for fixing this. As this is example code, would I be able to ...
9 years, 6 months ago (2012-04-17 08:59:01 UTC) #2
zhai
Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-04-17 12:44:42 UTC) #3
zhai
Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-04-17 13:15:20 UTC) #4
dfc
LGTM. Thank you for adding some nice examples.
9 years, 6 months ago (2012-04-18 00:03:45 UTC) #5
zhai
ping On Wed, Apr 18, 2012 at 8:03 AM, <dave@cheney.net> wrote: > LGTM. Thank you ...
9 years, 6 months ago (2012-04-21 00:08:19 UTC) #6
dfc
Assuming there is no more discussion, I'll submit this today. On Sat, Apr 21, 2012 ...
9 years, 6 months ago (2012-04-21 00:13:14 UTC) #7
dfc
*** Submitted as http://code.google.com/p/go/source/detail?r=23c94e7b3fd6 *** compress/zlib: minor fixes R=golang-dev, dave CC=golang-dev http://codereview.appspot.com/6058043 Committer: Dave Cheney ...
9 years, 6 months ago (2012-04-21 04:34:55 UTC) #8
gl
1 month, 1 week ago (2021-09-16 22:22:32 UTC) #9

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b