juju-restore: fix

juju-restore: fix

We can no longer log in to mongo with the
admin secret, so we change juju-restore
to use the machine agent credentials instead.

https://code.launchpad.net/~rogpeppe/juju-core/497-fix-restore/+merge/205127

(do not edit description out of merge proposal)

[rog, 2014-02-06 11:21:13]

Please take a look.

[dimitern, 2014-02-06 11:27:12]

Nice! LGTM, thanks for the progress updates.

[gz, 2014-02-06 11:42:33]

LGTM.

https://codereview.appspot.com/60580043/diff/1/cmd/plugins/juju-restore/resto...
File cmd/plugins/juju-restore/restore.go (right):

https://codereview.appspot.com/60580043/diff/1/cmd/plugins/juju-restore/resto...
cmd/plugins/juju-restore/restore.go:202: func progress(f string, a
...interface{}) {
Have mixed feelings about switching from log to printf, but guess it's pretty
easy to adapt later regardless. For now I guess less splurge is good.

https://codereview.appspot.com/60580043/diff/1/cmd/plugins/juju-restore/resto...
cmd/plugins/juju-restore/restore.go:285: func extractCreds(backupFile string)
(credentials, error) {
Now this would be a nice function to have independant tests for...

[rog, 2014-02-06 11:46:19]

https://codereview.appspot.com/60580043/diff/1/cmd/plugins/juju-restore/resto...
File cmd/plugins/juju-restore/restore.go (right):

https://codereview.appspot.com/60580043/diff/1/cmd/plugins/juju-restore/resto...
cmd/plugins/juju-restore/restore.go:202: func progress(f string, a
...interface{}) {
On 2014/02/06 11:42:34, gz wrote:
> Have mixed feelings about switching from log to printf, but guess it's pretty
> easy to adapt later regardless. For now I guess less splurge is good.

at least the printf style mixes well with the messages
printed by bootstrap.

also i can never remember how to make loggo print INFO level messages...

https://codereview.appspot.com/60580043/diff/1/cmd/plugins/juju-restore/resto...
cmd/plugins/juju-restore/restore.go:285: func extractCreds(backupFile string)
(credentials, error) {
On 2014/02/06 11:42:34, gz wrote:
> Now this would be a nice function to have independant tests for...

I'd prefer to have a CI test for the whole thing.
This function only makes sense in the context of the
file produced by juju-backup.