Issue 60080045: environs: deduplicate boilerplate config

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 60080045: environs: deduplicate boilerplate config

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by axw

Modified:
10 years, 2 months ago

Reviewers:
mp+204840, wallyworld

Visibility:
Public.

Description

environs: deduplicate boilerplate config Provider aliases (of which there is one: null->manual) cause duplicated boilerplate config. We now remember which boilerplate config templates have been seen, and deduplicate. Drive by addition of test to provider/manual for alias. Fixes lp:1275806 https://code.launchpad.net/~axwalk/juju-core/lp1275806-manual-duplicate-boilerplate/+merge/204840 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: deduplicate boilerplate config #

Total comments: 2

Patch Set 3 : environs: deduplicate boilerplate config #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -10 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/boilerplate_config_test.go	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download
M	environs/config.go	View	1	2 chunks	+21 lines, -5 lines	0 comments	Download
M	environs/config_test.go	View	1 2	1 chunk	+87 lines, -0 lines	0 comments	Download
M	environs/export_test.go	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download
M	provider/manual/provider.go	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	provider/manual/provider_test.go	View	1 2	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

wallyworld

LGTM but I'd like to see tests for RegisterProvider() and Provider() to cover the additional ...

10 years, 2 months ago (2014-02-10 05:54:51 UTC) #3

axw

10 years, 2 months ago (2014-02-10 10:37:27 UTC) #4

Please take a look.

https://codereview.appspot.com/60080045/diff/20001/provider/manual/provider_t...
File provider/manual/provider_test.go (right):

https://codereview.appspot.com/60080045/diff/20001/provider/manual/provider_t...
provider/manual/provider_test.go:39: c.Assert(err, gc.IsNil)
On 2014/02/10 05:54:52, wallyworld wrote:
> Could we also just check that the return result is gc.NotNil (to be pedantic)

Done.

Expand All Messages | Collapse All Messages