Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(242)

Issue 5992071: code review 5992071: html, exp/html: escape ' and " as ' and ", sinc... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by nigeltao
Modified:
9 years, 9 months ago
Reviewers:
CC:
rsc, MikeSamuel, dsymonds, golang-dev
Visibility:
Public.

Description

html, exp/html: escape ' and " as ' and ", since IE8 and below do not support '. This makes package html consistent with package text/template's HTMLEscape function. Fixes issue 3489.

Patch Set 1 #

Patch Set 2 : diff -r 734071724054 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 734071724054 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 734071724054 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r b9cbd32246e3 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -15 lines) Patch
M src/pkg/exp/html/escape.go View 1 2 3 4 2 chunks +5 lines, -3 lines 0 comments Download
M src/pkg/exp/html/render_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/html/token_test.go View 1 4 chunks +6 lines, -5 lines 0 comments Download
M src/pkg/html/escape.go View 1 2 3 4 2 chunks +5 lines, -3 lines 0 comments Download
M src/pkg/net/http/server.go View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M src/pkg/text/template/funcs.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
nigeltao
Hello rsc@golang.org, mikesamuel@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 9 months ago (2012-04-09 01:10:06 UTC) #1
dsymonds
LGTM
9 years, 9 months ago (2012-04-09 04:35:25 UTC) #2
MikeSamuel
2012/4/8 <nigeltao@golang.org>: > Reviewers: rsc, MikeSamuel, > > Message: > Hello rsc@golang.org, mikesamuel@gmail.com (cc: > ...
9 years, 9 months ago (2012-04-09 15:00:55 UTC) #3
rsc
Please note that this is more than an IE8 issue. &apos; did not exist in ...
9 years, 9 months ago (2012-04-09 19:01:56 UTC) #4
nigeltao
9 years, 9 months ago (2012-04-11 23:35:49 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=a70135896879 ***

html, exp/html: escape ' and " as &#39; and &#34;, since IE8 and
below do not support &apos;.

This makes package html consistent with package text/template's
HTMLEscape function.

Fixes issue 3489.

R=rsc, mikesamuel, dsymonds
CC=golang-dev
http://codereview.appspot.com/5992071
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b