Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(201)

Unified Diff: src/cmd/5l/asm.c

Issue 5987063: code review 5987063: cmd/5l: use GOARM=7 to gate the VFPv3-only "vmov (imm)"... (Closed)
Patch Set: diff -r 7f6a0510d3c9 https://code.google.com/p/go/ Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/cmd/5l/l.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/cmd/5l/asm.c
===================================================================
--- a/src/cmd/5l/asm.c
+++ b/src/cmd/5l/asm.c
@@ -2192,7 +2192,9 @@
int
chipzero(Ieee *e)
{
- if(e->l != 0 || e->h != 0)
+ // if this procedure returns 0, then 5l will use the "vmov (imm)"
+ // instruction which only exists on VFPv3. We use GOARM=7 to gate it.
+ if(goarm < 7 || e->l != 0 || e->h != 0)
return -1;
return 0;
}
@@ -2203,6 +2205,11 @@
int n;
ulong h;
+ // if this procedure returns non-negative number 5l will use the "vmov (imm)"
+ // instruction which only exists on VFPv3. We use GOARM=7 to gate it.
+ if(goarm < 7)
+ goto no;
+
if(e->l != 0 || (e->h&0xffff) != 0)
goto no;
h = e->h & 0x7fc00000;
« no previous file with comments | « no previous file | src/cmd/5l/l.h » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b