Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(416)

Issue 5946046: store: add CharmInfo.BundleSize

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by niemeyer
Modified:
12 years ago
Reviewers:
mp+99862, rog
Visibility:
Public.

Description

store: add CharmInfo.BundleSize https://code.launchpad.net/~niemeyer/juju/go-store-info-size/+merge/99862 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : store: add CharmInfo.BundleSize #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M store/store.go View 6 chunks +19 lines, -1 line 1 comment Download
M store/store_test.go View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
niemeyer
Please take a look.
12 years ago (2012-03-29 04:15:19 UTC) #1
niemeyer
*** Submitted: store: add CharmInfo.BundleSize R= CC= https://codereview.appspot.com/5946046
12 years ago (2012-03-29 04:58:11 UTC) #2
rog
12 years ago (2012-03-29 10:40:36 UTC) #3
LGTM

https://codereview.appspot.com/5946046/diff/1005/store/store.go
File store/store.go (right):

https://codereview.appspot.com/5946046/diff/1005/store/store.go#newcode236
store/store.go:236: charm := charmDoc{
i think this has enough fields that it would read better with field tags, but
YMMV. the same applies in the CharmInfo initialisation below.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b