Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4150)

Issue 5940054: Try to fix a windows warning. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by thakis
Modified:
12 years, 1 month ago
CC:
rlz-codereviews_googlegroups.com
Base URL:
https://rlz.googlecode.com/svn/trunk
Visibility:
Public.

Description

Try to fix a windows warning. win\lib\machine_id_win.cc(67): warning C4800: 'BOOL' : forcing value to bool 'true' or 'false' (performance warning) BUG=none TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M win/lib/machine_id_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
thakis
I had tested http://code.google.com/p/rlz/source/detail?r=122 locally with msvc 2010 in both debug and release builds before ...
12 years, 1 month ago (2012-03-28 14:10:30 UTC) #1
Roger Tawa (Google)
12 years, 1 month ago (2012-03-28 15:57:57 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b