Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1800)

Issue 5927044: rall. and accel stopped working in articulate.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Peter Chubb
Modified:
7 years, 2 months ago
Reviewers:
dak, carl.d.sorensen, thomas morley <thomasmorley65, peter, james <pkx166h, Graham Percival, pkx166h, Carl
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

rall. and accel stopped working in articulate. According to the the git logs, in February 2011 the way that tempo changes for MIDI were interpreted changed from just the tempoWholesPerMinute property to use a TempoChangeEvent. This broke rall. in articulated MIDI output. This patch brings the articulate script up-to-date wrt to the way that tempo changes are signalled, and also adds accel. and poco accel. to the list of accepted scripts. Reported-by: Thomas Morley <thomasmorley65@googlemail.com> Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -19 lines) Patch
M ly/articulate.ly View 5 chunks +46 lines, -19 lines 0 comments Download

Messages

Total messages: 6
Peter Chubb
Hi folks, Thomas Morley noticed that rall. had stopped causing tempo change in MIDI output ...
7 years, 3 months ago (2012-03-27 03:41:14 UTC) #1
Graham Percival
LGTM. You can send this to James for pushing whenever you want, provided that it ...
7 years, 3 months ago (2012-03-27 03:49:18 UTC) #2
Carl
LGTM
7 years, 3 months ago (2012-03-27 04:33:47 UTC) #3
dak
On 2012/03/27 03:49:18, Graham Percival wrote: > LGTM. You can send this to James for ...
7 years, 3 months ago (2012-03-27 05:48:48 UTC) #4
pkx166h
Peter, this has passed our 'countdown' review, if you don't yet have push access you ...
7 years, 2 months ago (2012-03-30 06:53:29 UTC) #5
peter_chubb.wattle.id.au
7 years, 2 months ago (2012-04-03 23:21:37 UTC) #6
>>>>> "pkx166h" == pkx166h  <pkx166h@gmail.com> writes:

pkx166h> Peter, this has passed our 'countdown' review, if you don't
pkx166h> yet have push access you can email me a git-formatted patch
pkx166h> and I can push it for you.

OK here it is.

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b