https://codereview.appspot.com/59250043/diff/20001/src/pkg/reflect/type.go File src/pkg/reflect/type.go (right): https://codereview.appspot.com/59250043/diff/20001/src/pkg/reflect/type.go#newcode241 src/pkg/reflect/type.go:241: AMEM uintptr = iota these should not be exported ...
10 years, 1 month ago
(2014-02-01 12:55:37 UTC)
#1
https://codereview.appspot.com/59250043/diff/20001/src/pkg/reflect/type.go File src/pkg/reflect/type.go (right): https://codereview.appspot.com/59250043/diff/20001/src/pkg/reflect/type.go#newcode239 src/pkg/reflect/type.go:239: // Algorithm types, defined in src/cmd/gc.h. The constants are ...
10 years, 1 month ago
(2014-02-01 19:41:35 UTC)
#2
On 2014/02/03 18:14:24, BenjaminP wrote: > > https://codereview.appspot.com/59250043/diff/20001/src/pkg/reflect/type.go#newcode1873 > src/pkg/reflect/type.go:1873: array.alg = &alg > On ...
10 years, 1 month ago
(2014-02-03 18:39:25 UTC)
#4
On 2014/02/03 18:14:24, BenjaminP wrote:
>
>
https://codereview.appspot.com/59250043/diff/20001/src/pkg/reflect/type.go#ne...
> src/pkg/reflect/type.go:1873: array.alg = &alg
> On 2014/02/01 19:41:35, iant wrote:
> > The tricky part is setting array.alg for the other cases.
>
> Could you clarify the cases where it doesn't work and why it doesn't work?
>
> I am motivated to resolve these problems, but after looking through the source
> I'm not sure I fully understand the complicated cases that need to be solved.
I
> would be happy to keep working to implement this feature once I understand
this,
> though. Thanks!
What will your code do for reflect.ArrayOf(3, reflect.TypeOf("")) ?
If I pass the resulting reflect.Type to reflect.MakeMap, will the map work
correctly?
Ian
Issue 59250043: reflect: Fill in remaining fields of ArrayOf and export...
Created 10 years, 1 month ago by BenjaminP
Modified 10 years, 1 month ago
Reviewers: golang-dev, bradfitz, iant
Base URL:
Comments: 9