Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1070)

Issue 59250043: reflect: Fill in remaining fields of ArrayOf and export...

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by BenjaminP
Modified:
10 years, 1 month ago
Reviewers:
golang-dev, iant, bradfitz
CC:
bjornick, toddw_google.com
Visibility:
Public.

Description

reflect: Fill in remaining fields of ArrayOf and export the function.

Patch Set 1 #

Patch Set 2 : diff -r 2fcaec19e523 https://code.google.com/p/go/ #

Total comments: 9

Patch Set 3 : diff -r ab7e873d13bd https://code.google.com/p/go/ #

Patch Set 4 : diff -r ab7e873d13bd https://code.google.com/p/go/ #

Patch Set 5 : diff -r ab7e873d13bd https://code.google.com/p/go/ #

Patch Set 6 : diff -r ab7e873d13bd https://code.google.com/p/go/ #

Patch Set 7 : diff -r ab7e873d13bd https://code.google.com/p/go/ #

Patch Set 8 : diff -r ab7e873d13bd https://code.google.com/p/go/ #

Patch Set 9 : diff -r ab7e873d13bd https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -7 lines) Patch
M src/cmd/gc/go.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/reflect/export_test.go View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/reflect/type.go View 1 2 3 4 5 6 7 8 3 chunks +111 lines, -5 lines 0 comments Download

Messages

Total messages: 4
bradfitz
https://codereview.appspot.com/59250043/diff/20001/src/pkg/reflect/type.go File src/pkg/reflect/type.go (right): https://codereview.appspot.com/59250043/diff/20001/src/pkg/reflect/type.go#newcode241 src/pkg/reflect/type.go:241: AMEM uintptr = iota these should not be exported ...
10 years, 1 month ago (2014-02-01 12:55:37 UTC) #1
iant
https://codereview.appspot.com/59250043/diff/20001/src/pkg/reflect/type.go File src/pkg/reflect/type.go (right): https://codereview.appspot.com/59250043/diff/20001/src/pkg/reflect/type.go#newcode239 src/pkg/reflect/type.go:239: // Algorithm types, defined in src/cmd/gc.h. The constants are ...
10 years, 1 month ago (2014-02-01 19:41:35 UTC) #2
BenjaminP
https://codereview.appspot.com/59250043/diff/20001/src/pkg/reflect/type.go File src/pkg/reflect/type.go (right): https://codereview.appspot.com/59250043/diff/20001/src/pkg/reflect/type.go#newcode241 src/pkg/reflect/type.go:241: AMEM uintptr = iota On 2014/02/01 12:55:37, bradfitz wrote: ...
10 years, 1 month ago (2014-02-03 18:14:24 UTC) #3
iant
10 years, 1 month ago (2014-02-03 18:39:25 UTC) #4
On 2014/02/03 18:14:24, BenjaminP wrote:
> 
>
https://codereview.appspot.com/59250043/diff/20001/src/pkg/reflect/type.go#ne...
> src/pkg/reflect/type.go:1873: array.alg = &alg
> On 2014/02/01 19:41:35, iant wrote:
> > The tricky part is setting array.alg for the other cases.
> 
> Could you clarify the cases where it doesn't work and why it doesn't work?
> 
> I am motivated to resolve these problems, but after looking through the source
> I'm not sure I fully understand the complicated cases that need to be solved.
I
> would be happy to keep working to implement this feature once I understand
this,
> though. Thanks!

What will your code do for reflect.ArrayOf(3, reflect.TypeOf("")) ?

If I pass the resulting reflect.Type to reflect.MakeMap, will the map work
correctly?

Ian
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b