Change all occurences of "echo -n" to "printf" for portability

Change all occurences of "echo -n" to "printf" for portability

[dak, 2012-03-24 06:00:52]

http://codereview.appspot.com/5903046/diff/1/scripts/build/install-info-html.sh
File scripts/build/install-info-html.sh (right):

http://codereview.appspot.com/5903046/diff/1/scripts/build/install-info-html....
scripts/build/install-info-html.sh:129: printf "$name: Writing index:
$index_file..."
This is dangerous since $name could contain print control characters.  So one
should rather write
printf "%s: Writing index: %s..." "$name" "$index_file..."

http://codereview.appspot.com/5903046/diff/1/smart-autogen.sh
File smart-autogen.sh (right):

http://codereview.appspot.com/5903046/diff/1/smart-autogen.sh#newcode16
smart-autogen.sh:16: printf $AUTOGEN_INPUT_CHECKSUM > $CHECKSUM_FILE
I'd prefer "%s" "$AUTOGEN_INPUT_CHECKSUM" here too in order to avoid teaching
sloppy use of printf, but it can't actually do harm here since md5sum does not
produce backslashes or percent characters.

http://codereview.appspot.com/5903046/diff/1/smart-configure.sh
File smart-configure.sh (right):

http://codereview.appspot.com/5903046/diff/1/smart-configure.sh#newcode19
smart-configure.sh:19: printf $CONFIGURE_CHECKSUM > $CONFIGURE_CHECKSUM_FILE
See last comment.

http://codereview.appspot.com/5903046/diff/1/stepmake/bin/stepmakeise.sh
File stepmake/bin/stepmakeise.sh (right):

http://codereview.appspot.com/5903046/diff/1/stepmake/bin/stepmakeise.sh#newc...
stepmake/bin/stepmakeise.sh:37: printf "Checking version..."
Good enough: literal string without control or format characters is harmless.

[dak, 2012-03-24 06:34:44]

http://codereview.appspot.com/5903046/diff/1/smart-autogen.sh
File smart-autogen.sh (right):

http://codereview.appspot.com/5903046/diff/1/smart-autogen.sh#newcode16
smart-autogen.sh:16: printf $AUTOGEN_INPUT_CHECKSUM > $CHECKSUM_FILE
On 2012/03/24 06:00:52, dak wrote:
> I'd prefer "%s" "$AUTOGEN_INPUT_CHECKSUM" here too in order to avoid teaching
> sloppy use of printf, but it can't actually do harm here since md5sum does not
> produce backslashes or percent characters.

And while we are at it: the trailing whitespace could be removed as well.

[dak, 2012-03-24 16:27:31]

http://codereview.appspot.com/5903046/diff/6001/smart-autogen.sh
File smart-autogen.sh (right):

http://codereview.appspot.com/5903046/diff/6001/smart-autogen.sh#newcode16
smart-autogen.sh:16: printf "%s" $AUTOGEN_INPUT_CHECKSUM > $CHECKSUM_FILE
Remove trailing space in this line before pushing.

[Graham Percival, 2012-03-26 06:02:09]

LGTM, I think this could be pushed immediately?

[dak, 2012-03-26 08:07:58]

On 2012/03/26 06:02:09, Graham Percival wrote:
> LGTM, I think this could be pushed immediately?

I would be surprised if there was any part in it that could still benefit from
further review/countdown.