Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1399)

Issue 5874049: use readable time stamps on log messages.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by rog
Modified:
8 years, 2 months ago
Reviewers:
niemeyer, mp+98841
Visibility:
Public.

Description

use readable time stamps on log messages. [Re-opening this because AFAICS a fix for this has never landed, and currently gocheck always prints an identical time stamp because the time calculation overflows.] On long running tests, I was seeing log output like this: [LOG] 72.15087 JUJU state: opening state; zookeeper addresses: ["ec2-23-20-157-185.compute-1.amazonaws.com:2181"] [LOG] 78.46405 JUJU state: waiting for state to be initialized destroy env [LOG] 13.73135 JUJU environs/ec2: destroying environment "sample-6326978ae3647455" This CL makes the time stamp format as a duration since the start of the test. For instance: [LOG] 0:00.568 DEBUG juju.environs.tools reading v1.* tools [LOG] 0:00.569 INFO juju environs/testing: uploading FAKE tools 1.17.3-trusty-amd64 [LOG] 0:00.570 INFO juju environs/testing: uploading FAKE tools 1.17.3-precise-amd64 [LOG] 0:00.571 DEBUG juju.environs.tools no architecture specified when finding tools, looking for any Note that five tests are currently failing on trunk - this patch does not fix that - the same tests fail in the same way. I have also gofmt'd the files which allow it (all but printer_test.go). https://code.launchpad.net/~rogpeppe/gocheck/monotonic-time-stamps/+merge/98841 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : use readable time stamps on log messages. #

Patch Set 3 : use readable time stamps on log messages. #

Patch Set 4 : use readable time stamps on log messages. #

Patch Set 5 : use readable time stamps on log messages. #

Patch Set 6 : use readable time stamps on log messages. #

Patch Set 7 : use readable time stamps on log messages. #

Patch Set 8 : use readable time stamps on log messages. #

Patch Set 9 : use readable time stamps on log messages. #

Patch Set 10 : use readable time stamps on log messages. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
A [revision details] View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M benchmark_test.go View 1 2 3 4 5 6 2 chunks +6 lines, -6 lines 0 comments Download
M bootstrap_test.go View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M foundation_test.go View 1 2 3 4 5 6 1 chunk +2 lines, -7 lines 0 comments Download
M gocheck.go View 1 2 3 4 5 6 7 4 chunks +10 lines, -9 lines 0 comments Download
M gocheck_test.go View 1 2 3 4 5 6 7 1 chunk +7 lines, -7 lines 0 comments Download
M helpers.go View 1 2 3 4 1 chunk +6 lines, -3 lines 0 comments Download
M run.go View 1 2 3 4 5 6 7 2 chunks +5 lines, -5 lines 0 comments Download
M run_test.go View 1 2 3 4 5 6 7 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5
rog
Please take a look.
10 years, 2 months ago (2012-03-22 14:01:22 UTC) #1
rog
Please take a look.
9 years, 8 months ago (2012-08-28 19:52:01 UTC) #2
niemeyer
This has already been fixed in the last release, following up a conversation we had ...
9 years, 2 months ago (2013-03-01 20:26:01 UTC) #3
rog
Please take a look.
8 years, 3 months ago (2014-02-18 17:08:57 UTC) #4
niemeyer
8 years, 2 months ago (2014-02-25 17:28:12 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b