Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1731)

Issue 5870043: A new home for browser-language (issue 2412). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Julien Rioux
Modified:
7 years, 3 months ago
Reviewers:
Graham Percival
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

A new home for browser-language (issue 2412). Copy the browser-language pages from origin/archive/web into Documentation/misc and rewrite the links. Their new home is under http://lilypond.org/misc.

Patch Set 1 #

Total comments: 1

Patch Set 2 : lilypond.org/misc -> lilypond.org/website/misc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+775 lines, -8 lines) Patch
A Documentation/misc/browser-language.html View 1 chunk +72 lines, -0 lines 0 comments Download
A Documentation/misc/browser-language.de.html View 1 chunk +141 lines, -0 lines 0 comments Download
A Documentation/misc/browser-language.es.html View 1 chunk +72 lines, -0 lines 0 comments Download
A Documentation/misc/browser-language.fr.html View 1 chunk +79 lines, -0 lines 0 comments Download
A Documentation/misc/browser-language.hu.html View 1 chunk +242 lines, -0 lines 0 comments Download
A Documentation/misc/browser-language.ja.html View 1 chunk +85 lines, -0 lines 0 comments Download
A Documentation/misc/browser-language.nl.html View 1 chunk +76 lines, -0 lines 0 comments Download
M python/auxiliar/postprocess_html.py View 1 2 chunks +3 lines, -6 lines 0 comments Download
M scripts/build/website_post.py View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Graham Percival
http://codereview.appspot.com/5870043/diff/1/python/auxiliar/postprocess_html.py File python/auxiliar/postprocess_html.py (right): http://codereview.appspot.com/5870043/diff/1/python/auxiliar/postprocess_html.py#newcode71 python/auxiliar/postprocess_html.py:71: browser_language_url = "/misc/browser-language" please change to /website/misc/browser-language. I'm not ...
7 years, 3 months ago (2012-03-21 15:33:10 UTC) #1
Julien Rioux
On Wed, Mar 21, 2012 at 4:33 PM, <graham@percival-music.ca> wrote: > > http://codereview.appspot.com/5870043/diff/1/python/auxiliar/postprocess_html.py > File ...
7 years, 3 months ago (2012-03-21 15:42:35 UTC) #2
Julien Rioux
On Wed, Mar 21, 2012 at 4:42 PM, Julien Rioux <julien.rioux@gmail.com> wrote: > On Wed, ...
7 years, 3 months ago (2012-03-21 17:00:25 UTC) #3
Graham Percival
7 years, 3 months ago (2012-03-23 04:09:53 UTC) #4
LGTM.

Somebody might complain that the translations of misc/ should go in their
respective directories, but I think that's overkill, and I'd really like to get
this patch in.  Removing old /web/ is finally within reach!  :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b