Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1754)

Issue 5862052: 2310 Corrected style of comments (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Milimetr88
Modified:
7 years, 2 months ago
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Corrected style of comments

Patch Set 1 #

Total comments: 11
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -42 lines) Patch
M .gitignore View 1 chunk +9 lines, -0 lines 0 comments Download
M flower/include/direction.hh View 2 chunks +19 lines, -1 line 2 comments Download
M lily/accidental-placement.cc View 6 chunks +15 lines, -5 lines 2 comments Download
M lily/grob.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M lily/include/grob-interface.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/note-collision.hh View 1 chunk +5 lines, -0 lines 0 comments Download
M lily/note-collision.cc View 16 chunks +51 lines, -32 lines 7 comments Download
M lily/note-column.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M lily/staff-symbol-referencer.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14
Milimetr88
This is a continuation of Issue: http://codereview.appspot.com/5651069/
7 years, 3 months ago (2012-03-21 18:55:31 UTC) #1
Julien Rioux
Are the changes to .gitignore intentional?
7 years, 3 months ago (2012-03-22 14:43:30 UTC) #2
Graham Percival
I really like seeing work on comments. Have you experimented with doxygen? If you're going ...
7 years, 3 months ago (2012-03-22 14:55:38 UTC) #3
Keith
This patch adds helpful comments. http://codereview.appspot.com/5862052/diff/1/flower/include/direction.hh File flower/include/direction.hh (right): http://codereview.appspot.com/5862052/diff/1/flower/include/direction.hh#newcode77 flower/include/direction.hh:77: * Thanks to a ...
7 years, 3 months ago (2012-03-23 07:23:36 UTC) #4
Milimetr88
On 22 March 2012 15:43, <julien.rioux@gmail.com> wrote: > Are the changes to .gitignore intentional? > ...
7 years, 3 months ago (2012-03-23 10:41:48 UTC) #5
Milimetr88
I'm sorry for that, but the next bunch of corrections are in a separate issue: ...
7 years, 2 months ago (2012-03-31 16:13:11 UTC) #6
janek
On Sat, Mar 31, 2012 at 6:13 PM, <milimetr88@gmail.com> wrote: > I'm sorry for that, ...
7 years, 2 months ago (2012-03-31 20:02:28 UTC) #7
pkx166h
Hello, 2012/3/31 Janek Warchoł <janek.lilypond@gmail.com>: > On Sat, Mar 31, 2012 at 6:13 PM, <milimetr88@gmail.com> ...
7 years, 2 months ago (2012-03-31 20:46:07 UTC) #8
Milimetr88
Thanku you, Janek and James. Wouldn't it be nicer for git cl to ask for ...
7 years, 2 months ago (2012-04-01 08:46:22 UTC) #9
Graham Percival
On Sun, Apr 01, 2012 at 10:46:01AM +0200, Łukasz Czerwiński wrote: > Thanku you, Janek ...
7 years, 2 months ago (2012-04-01 08:57:14 UTC) #10
janek
On Sun, Apr 1, 2012 at 10:57 AM, Graham Percival <graham@percival-music.ca> wrote: > On Sun, ...
7 years, 2 months ago (2012-04-01 09:01:04 UTC) #11
Graham Percival
On Sun, Apr 01, 2012 at 11:00:44AM +0200, Janek Warchoł wrote: > On Sun, Apr ...
7 years, 2 months ago (2012-04-01 09:21:39 UTC) #12
mail_philholmes.net
----- Original Message ----- From: "Graham Percival" <graham@percival-music.ca> To: "Janek Warchoł" <janek.lilypond@gmail.com> Cc: <k-ohara5a5a@oco.net>; <reply@codereview-hr.appspotmail.com>; ...
7 years, 2 months ago (2012-04-01 10:10:07 UTC) #13
Graham Percival
7 years, 2 months ago (2012-04-01 10:17:15 UTC) #14
On Sun, Apr 01, 2012 at 11:09:59AM +0100, Phil Holmes wrote:
> ----- Original Message ----- From: "Graham Percival"
> <graham@percival-music.ca>
> To: "Janek Warchoł" <janek.lilypond@gmail.com>
> Cc: <k-ohara5a5a@oco.net>; <reply@codereview-hr.appspotmail.com>;
> <julien.rioux@gmail.com>; <lilypond-devel@gnu.org>
> Sent: Sunday, April 01, 2012 10:21 AM
> Subject: Re: Corrected style of comments (issue 5862052)
> 
> >If you're sending patches from different computers, I think you
> >can do it with
> > git-cl issue 1234
> > git-cl upload
> 
> My recollection is that it assumes that the current issue number is
> the most recent you've uploaded to Rietveld.

It supposed to track it on a per-branch basis.  That's one reason
why the revised CG pushes (no pun intended) branches so heavily.

I mean, the CG now even covers branches in the "git for the
impatient", which is my absolutely shortest list of "I don't want
to learn anything about git; just give me commands to copy&paste
so I can improve lilypond".

- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b