state: wait for initialization before returning from Open.
Also remove Initialize from the set of State methods.
https://code.launchpad.net/~rogpeppe/juju/go-rearrange-state-initialization/+merge/98161
(do not edit description out of merge proposal)
https://codereview.appspot.com/5853048/diff/4001/state/state.go File state/state.go (right): https://codereview.appspot.com/5853048/diff/4001/state/state.go#newcode253 state/state.go:253: case <-time.After(3 * time.Minute): As discussed on IRC, I ...
12 years, 1 month ago
(2012-03-19 10:52:06 UTC)
#3
LGTM, only one small note. https://codereview.appspot.com/5853048/diff/6002/state/state_test.go File state/state_test.go (right): https://codereview.appspot.com/5853048/diff/6002/state/state_test.go#newcode112 state/state_test.go:112: time.Sleep(0.2e9) Nothing big, but ...
12 years, 1 month ago
(2012-03-19 13:16:53 UTC)
#6
Please take a look. https://codereview.appspot.com/5853048/diff/4016/state/open.go File state/open.go (right): https://codereview.appspot.com/5853048/diff/4016/state/open.go#newcode39 state/open.go:39: // the environment connected to. ...
12 years, 1 month ago
(2012-03-19 14:26:10 UTC)
#10
Please take a look.
https://codereview.appspot.com/5853048/diff/4016/state/open.go
File state/open.go (right):
https://codereview.appspot.com/5853048/diff/4016/state/open.go#newcode39
state/open.go:39: // the environment connected to.
On 2012/03/19 14:04:32, niemeyer wrote:
> The "ZooKeeper node" term is used to refer to the filesystem entries rather
than
> the servers. I suggest something like this:
>
> // Initialize sets up an initial empty state in ZooKeeper
> // and returns it. This needs to be preformed only once
> // for a given cluster of ZooKeeper servers.
Done.
*** Submitted: state: wait for initialization before returning from Open. Also remove Initialize from the ...
12 years, 1 month ago
(2012-03-19 14:33:12 UTC)
#13
*** Submitted:
state: wait for initialization before returning from Open.
Also remove Initialize from the set of State methods.
R=fwereade, TheMue, niemeyer
CC=
https://codereview.appspot.com/5853048
Issue 5853048: state: wait for initialization before returning from Open.
Created 12 years, 1 month ago by rog
Modified 12 years, 1 month ago
Reviewers: mp+98161_code.launchpad.net
Base URL:
Comments: 7